Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1709373002: Make Date.prototype.toGMTString an alias for Date.prototype.toUTCString (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Date.prototype.toGMTString an alias for Date.prototype.toUTCString In ES2015, Date.prototype.toGMTString is simply an alias of Date.prototype.toUTCString, so it has the same identity as a function and doesn't have its own name. Firefox has already shipped this behavior. Previously, we copied JSC behavior by making it a separate function. This change makes an addition test262 test pass. BUG=v8:4708 LOG=Y R=adamk Committed: https://crrev.com/44f9c6a63874a838e6c9cc2858cdbd34884fd4db Cr-Commit-Position: refs/heads/master@{#34131}

Patch Set 1 #

Patch Set 2 : test262 test passes #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M src/bootstrapper.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M test/mjsunit/function-names.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709373002/1
4 years, 10 months ago (2016-02-19 00:54:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709373002/20001
4 years, 10 months ago (2016-02-19 00:55:22 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/3154) v8_win64_rel_ng_triggered on ...
4 years, 10 months ago (2016-02-19 01:12:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709373002/40001
4 years, 10 months ago (2016-02-19 01:26:04 UTC) #8
Dan Ehrenberg
4 years, 10 months ago (2016-02-19 02:04:03 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-19 02:13:24 UTC) #11
adamk
lgtm For the record, JSC still appears to have the old behavior.
4 years, 10 months ago (2016-02-19 02:16:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709373002/40001
4 years, 10 months ago (2016-02-19 02:17:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-19 02:18:54 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/44f9c6a63874a838e6c9cc2858cdbd34884fd4db Cr-Commit-Position: refs/heads/master@{#34131}
4 years, 10 months ago (2016-02-19 02:19:04 UTC) #17
Benedikt Meurer
4 years, 10 months ago (2016-02-19 04:47:41 UTC) #19
Message was sent while issue was closed.
Nice!

Powered by Google App Engine
This is Rietveld 408576698