Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1709363003: Both unit and library sources must be isInSystemLibrary. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Both unit and library sources must be isInSystemLibrary. This fixes the last failure with shared tests and SDK summary. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ee4b4b85bd26194ce89a46e647c8c7bf307d6777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 10 months ago (2016-02-19 22:02:29 UTC) #1
Paul Berry
lgtm
4 years, 10 months ago (2016-02-19 22:05:17 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as ee4b4b85bd26194ce89a46e647c8c7bf307d6777 (presubmit successful).
4 years, 10 months ago (2016-02-19 22:06:01 UTC) #4
Brian Wilkerson
4 years, 10 months ago (2016-02-19 22:37:31 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698