Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1709353002:
Improve clarity of Physical Web opt-in notification (Closed)
|
Created:
4 years, 10 months ago by mattreynolds Modified:
4 years, 10 months ago Reviewers:
nyquist CC:
chromium-reviews, cco3, mmocny Base URL:
https://chromium.googlesource.com/chromium/src.git@2623 Target Ref:
refs/pending/branch-heads/2623 Project:
chromium Visibility:
Public. |
DescriptionImprove clarity of Physical Web opt-in notification
The previous notification message did not communicate what the Physical Web
is or why users should turn it on. Additionally, there was little
indication that the notification came from Chrome and not a separate app.
This change updates the notification text and icon to soften the
introduction.
BUG=583541
NOTRY=true
NOPRESUBMIT=true
(cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f)
Original review URL: https://codereview.chromium.org/1664673003/ .
Patch Set 1 #
Messages
Total messages: 21 (11 generated)
The CQ bit was checked by mattreynolds@chromium.org
The CQ bit was unchecked by mattreynolds@chromium.org
The CQ bit was checked by mattreynolds@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
mattreynolds@chromium.org changed reviewers: + nyquist@chromium.org
Hi Tommy, can you take a look and make sure we're correctly applying this to the M49 branch?
Description was changed from ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 ========== to ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 (cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f) Original review URL: https://codereview.chromium.org/1664673003/ . ==========
lgtm
The CQ bit was checked by nyquist@chromium.org
On 2016/02/18 23:02:27, mattreynolds wrote: > Hi Tommy, can you take a look and make sure we're correctly applying this to the > M49 branch? Yeah, if you look at the Base URL to the left, you'll see: https://chromium.googlesource.com/chromium/src.git@2623. That part after the @ is the correct branch number for M49.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709353002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 (cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f) Original review URL: https://codereview.chromium.org/1664673003/ . ========== to ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 NOTRY=true NOPRESUBMIT=true (cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f) Original review URL: https://codereview.chromium.org/1664673003/ . ==========
Adding suggested headers from commit-bot since I'm not the author of this cherry-pick.
The CQ bit was checked by nyquist@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709353002/1
Message was sent while issue was closed.
Description was changed from ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 NOTRY=true NOPRESUBMIT=true (cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f) Original review URL: https://codereview.chromium.org/1664673003/ . ========== to ========== Improve clarity of Physical Web opt-in notification The previous notification message did not communicate what the Physical Web is or why users should turn it on. Additionally, there was little indication that the notification came from Chrome and not a separate app. This change updates the notification text and icon to soften the introduction. BUG=583541 NOTRY=true NOPRESUBMIT=true (cherry picked from commit 02432cab3b500ba797b9ecfc67e10d0e1ce9be8f) Original review URL: https://codereview.chromium.org/1664673003/ . ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
