Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-expected.cc

Issue 1709343002: Remove tools/clang (this will break things temporarily). Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-expected.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-expected.cc
deleted file mode 100644
index 00435f031472463a2eefedebf31bda646c0b6ac0..0000000000000000000000000000000000000000
--- a/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-expected.cc
+++ /dev/null
@@ -1,24 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "scoped_refptr.h"
-
-struct Foo {
- int dummy;
-};
-
-// A temporary scoped_refptr is passed as a raw pointer function argument. Since
-// temporaries are destroyed at the end of the full expression, this is 'safe'
-// and could be rewritten to use get(). However, the tool just skips this case
-// This should be rare enough that manual intervention is sufficient, since
-// seeing this pattern probably indicates a code smell.
-scoped_refptr<Foo> GetBuggyFoo() {
- return new Foo;
-}
-
-void Bar(Foo* f);
-
-void UseBuggyFoo() {
- Bar(GetBuggyFoo());
-}

Powered by Google App Engine
This is Rietveld 408576698