Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1709333002: Remove mojom_fetcher. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove mojom_fetcher. * No one uses it (and no one is maintaining it). * It depends on the old mojom parser. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/86ddbb7fc8503c011bdb50d06ce7b30a94b3e643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -1244 lines) Patch
D mojo/public/tools/mojom_fetcher/build_gn.tmpl View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/mojom_fetcher.py View 1 chunk +0 lines, -196 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/mojom_gn.py View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/pylib/fetcher/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/pylib/fetcher/dependency.py View 1 chunk +0 lines, -180 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/pylib/fetcher/mojom_directory.py View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/pylib/fetcher/mojom_file.py View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/tools/mojom_fetcher/pylib/fetcher/repository.py View 1 chunk +0 lines, -115 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/dependency_tests.py View 1 chunk +0 lines, -110 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/fakes.py View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/mojom_directory_tests.py View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/mojom_fetcher_tests.py View 1 chunk +0 lines, -109 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/mojom_file_tests.py View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/mojom_gn_tests.py View 1 chunk +0 lines, -88 lines 0 comments Download
D mojo/tools/testing/mojom_fetcher/repository_tests.py View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-18 21:47:05 UTC) #1
jamesr
lgtm
4 years, 10 months ago (2016-02-18 21:49:35 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-18 21:51:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
86ddbb7fc8503c011bdb50d06ce7b30a94b3e643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698