Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 1709273003: Make function lookup in classes thread-safe: (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make function lookup in classes thread-safe: - Do not create/add function when looking them up in TryCreatICData - Do not allow background compilation to add/remove functions - Cache function hash array as it may change or be set to null. Check VMObject only if FLAG_verify_handles is true. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/8e23dcced3a5f7521a08ef5eeecaaa3bef87c3f2

Patch Set 1 #

Patch Set 2 : c #

Total comments: 2

Patch Set 3 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -26 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/hash_table.h View 3 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +4 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 1 2 5 chunks +26 lines, -7 lines 0 comments Download
M runtime/vm/resolver.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/resolver.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 10 months ago (2016-02-18 22:51:28 UTC) #2
siva
lgtm https://codereview.chromium.org/1709273003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1709273003/diff/20001/runtime/vm/object.cc#newcode3953 runtime/vm/object.cc:3953: Array& hash_table = Array::Handle(thread->zone(), const Array& hash_table =
4 years, 10 months ago (2016-02-18 23:56:50 UTC) #3
srdjan
https://codereview.chromium.org/1709273003/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1709273003/diff/20001/runtime/vm/object.cc#newcode3953 runtime/vm/object.cc:3953: Array& hash_table = Array::Handle(thread->zone(), On 2016/02/18 23:56:50, siva wrote: ...
4 years, 10 months ago (2016-02-19 00:01:25 UTC) #4
srdjan
4 years, 10 months ago (2016-02-19 00:03:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8e23dcced3a5f7521a08ef5eeecaaa3bef87c3f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698