Update SkImageFilter's cache to handle SkSpecialImages and add unit test

Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709263002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/df7bb471e5455dece2784a970d9ae50d3ab0ca75

[robertphillips, 2016-02-18 20:02:02]

Description was changed from

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test
==========

to

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-02-18 20:10:18]

Description was changed from

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get
OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-02-18 20:10:19]

robertphillips@google.com changed reviewers:
+ senorblanco@google.com

[Stephen White, 2016-02-18 21:14:28]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-02-18 21:14:28]

LGTM

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
File tests/ImageFilterCacheTest.cpp (right):

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
tests/ImageFilterCacheTest.cpp:134: SkBitmap srcBM = create_bm();
Not sure I understand why these paths are testing the SkBitmap path. Shouldn't
they be testing the SkSpecialImage path instead?

[robertphillips, 2016-02-19 15:27:10]

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
File tests/ImageFilterCacheTest.cpp (right):

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
tests/ImageFilterCacheTest.cpp:134: SkBitmap srcBM = create_bm();
They should be testing the raster, gpu, and SkImage -backed SkSpecialImage
paths. I should only be using the initial bitmap to create the SkSpecialImages.

[robertphillips, 2016-02-19 15:28:29]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 15:28:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709263002/40001

[robertphillips, 2016-02-19 15:29:13]

Description was changed from

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get
OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get
OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

[robertphillips, 2016-02-19 15:29:13]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[Stephen White, 2016-02-19 15:32:09]

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
File tests/ImageFilterCacheTest.cpp (right):

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
tests/ImageFilterCacheTest.cpp:134: SkBitmap srcBM = create_bm();
On 2016/02/19 15:27:10, robertphillips wrote:
> They should be testing the raster, gpu, and SkImage -backed SkSpecialImage
> paths. I should only be using the initial bitmap to create the
SkSpecialImages.

Shouldn't we be creating an SkImage, then doing a NewFromImage() on that? Isn't
the SkBitmap path in SkSpecialImage going to go away at some point?

[commit-bot: I haz the power, 2016-02-19 15:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 15:58:35]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-19 16:04:53]

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
File tests/ImageFilterCacheTest.cpp (right):

https://codereview.chromium.org/1709263002/diff/40001/tests/ImageFilterCacheT...
tests/ImageFilterCacheTest.cpp:134: SkBitmap srcBM = create_bm();
Right - once images are everywhere the _RasterBacked and _GPUBacked cases will
go away and only the _ImageBacked flavor will remain.

I will add an _ImageBacked variant with a GrTexture behind it.

[robertphillips, 2016-02-19 16:18:28]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-02-19 16:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709263002/40001

[commit-bot: I haz the power, 2016-02-19 16:19:47]

Description was changed from

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get
OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

to

==========
Update SkImageFilter's cache to handle SkSpecialImages and add unit test

This is calved off of: https://codereview.chromium.org/1695823002/ (Get
OffsetImageFilter really working with SkSpecialImages)

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/df7bb471e5455dece2784a970d9ae50d3ab0ca75
==========

[commit-bot: I haz the power, 2016-02-19 16:19:48]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/df7bb471e5455dece2784a970d9ae50d3ab0ca75