Add link to how to generate new SKPs when increasing the picture version

Add link to how to generate new SKPs when increasing the picture version

BUG=skia:2041
Committed: http://code.google.com/p/skia/source/detail?r=13493

[rmistry, 2014-02-18 19:33:46]

What do you guys think about adding this messaging around the picture version.

[scroggo, 2014-02-18 19:55:01]

lgtm

On 2014/02/18 19:33:46, rmistry wrote:
> What do you guys think about adding this messaging around the picture version.

I think it's a great idea!

(Would it be possible to automate more of the steps in the doc?)

https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h...
include/core/SkPicture.h:242: // Note: If the picture version needs to be
increased then please follow the
Maybe a newline after the last version, so the note will stand out more?

[rmistry, 2014-02-18 20:00:17]

On 2014/02/18 19:55:01, scroggo wrote:
> lgtm
> 
> On 2014/02/18 19:33:46, rmistry wrote:
> > What do you guys think about adding this messaging around the picture
version.
> 
> I think it's a great idea!
> 
> (Would it be possible to automate more of the steps in the doc?)

I originally had it where running the trybot would automatically copy the SKPs
to the right production location but that could result in problems especially
when the CL that changed the version is not landed first or when the new SKPs
are not validated.
There are a bunch of steps but hopefully following the steps will lead to no
tree failures.

> 
> https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h
> File include/core/SkPicture.h (right):
> 
>
https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h...
> include/core/SkPicture.h:242: // Note: If the picture version needs to be
> increased then please follow the
> Maybe a newline after the last version, so the note will stand out more?

[rmistry, 2014-02-18 20:00:21]

https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/170923003/diff/30001/include/core/SkPicture.h...
include/core/SkPicture.h:242: // Note: If the picture version needs to be
increased then please follow the
On 2014/02/18 19:55:01, scroggo wrote:
> Maybe a newline after the last version, so the note will stand out more?

Done.

[rmistry, 2014-02-18 21:57:13]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-02-18 21:57:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/rmistry@google.com/170923003/50001

[commit-bot: I haz the power, 2014-02-18 21:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-18 21:57:26]

Presubmit check for 170923003-50001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com')

[rmistry, 2014-02-18 22:03:06]

Brian/Mike can one of you please LGTM. Thanks

[bsalomon, 2014-02-18 22:07:56]

On 2014/02/18 22:03:06, rmistry wrote:
> Brian/Mike can one of you please LGTM. Thanks

lgtm

[rmistry, 2014-02-18 22:08:09]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-02-18 22:08:12]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/rmistry@google.com/170923003/50001

[commit-bot: I haz the power, 2014-02-18 22:08:18]

Change committed as 13493