Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 170913002: Add InputRouter perftests for touches and scroll gestures (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
jam, tdresser
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add InputRouter perftests for touches and scroll gestures Add some basic perftests that track how long a given WebTouchEvent or WebGestureEvent takes to propagate through the InputRouter. This includes both the time to send and the time to ack a given event, averaged over a typical touch swipe or scroll gesture sequence. BUG=339877 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252079

Patch Set 1 #

Patch Set 2 : Updates #

Total comments: 10

Patch Set 3 : Cleanup #

Patch Set 4 : Cleanup #

Patch Set 5 : Address nits #

Patch Set 6 : Updates #

Patch Set 7 : Flags export for testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -1 line) Patch
A content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 2 3 4 5 1 chunk +389 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 3 chunks +22 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
jdduke (slow)
tdresser@: PTAL. This is a fairly braindead test, but it picks up changes in the ...
6 years, 10 months ago (2014-02-18 18:52:20 UTC) #1
tdresser
LGTM with nits. https://codereview.chromium.org/170913002/diff/30001/content/browser/renderer_host/input/input_router_impl_perftest.cc File content/browser/renderer_host/input/input_router_impl_perftest.cc (right): https://codereview.chromium.org/170913002/diff/30001/content/browser/renderer_host/input/input_router_impl_perftest.cc#newcode1 content/browser/renderer_host/input/input_router_impl_perftest.cc:1: // Copyright 2013 The Chromium Authors. ...
6 years, 10 months ago (2014-02-18 19:45:59 UTC) #2
jdduke (slow)
https://codereview.chromium.org/170913002/diff/30001/content/browser/renderer_host/input/input_router_impl_perftest.cc File content/browser/renderer_host/input/input_router_impl_perftest.cc (right): https://codereview.chromium.org/170913002/diff/30001/content/browser/renderer_host/input/input_router_impl_perftest.cc#newcode1 content/browser/renderer_host/input/input_router_impl_perftest.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
6 years, 10 months ago (2014-02-18 20:16:10 UTC) #3
jdduke (slow)
jam@: Review for content_tests.gypi? Thanks.
6 years, 10 months ago (2014-02-18 20:17:02 UTC) #4
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 00:24:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/70002
6 years, 10 months ago (2014-02-19 00:25:34 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 02:19:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=73325
6 years, 10 months ago (2014-02-19 02:19:08 UTC) #8
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 06:10:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/70003
6 years, 10 months ago (2014-02-19 06:11:32 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 07:02:31 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=178586
6 years, 10 months ago (2014-02-19 07:02:32 UTC) #12
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 07:07:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/70003
6 years, 10 months ago (2014-02-19 07:07:56 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 08:09:59 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=178596
6 years, 10 months ago (2014-02-19 08:10:00 UTC) #16
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-19 14:30:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/790001
6 years, 10 months ago (2014-02-19 14:31:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/790001
6 years, 10 months ago (2014-02-19 15:03:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/170913002/790001
6 years, 10 months ago (2014-02-19 15:32:48 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 20:59:10 UTC) #21
Message was sent while issue was closed.
Change committed as 252079

Powered by Google App Engine
This is Rietveld 408576698