Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 17091002: Hydrogen array constructor cleanup and improvements (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed nit Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 constructor()->PrintTo(stream); 319 constructor()->PrintTo(stream);
320 stream->Add(" #%d / ", arity()); 320 stream->Add(" #%d / ", arity());
321 } 321 }
322 322
323 323
324 void LCallNewArray::PrintDataTo(StringStream* stream) { 324 void LCallNewArray::PrintDataTo(StringStream* stream) {
325 stream->Add("= "); 325 stream->Add("= ");
326 constructor()->PrintTo(stream); 326 constructor()->PrintTo(stream);
327 stream->Add(" #%d / ", arity()); 327 stream->Add(" #%d / ", arity());
328 ASSERT(hydrogen()->property_cell()->value()->IsSmi()); 328 ASSERT(hydrogen()->property_cell()->value()->IsSmi());
329 ElementsKind kind = static_cast<ElementsKind>( 329 ElementsKind kind = hydrogen()->elements_kind();
330 Smi::cast(hydrogen()->property_cell()->value())->value());
331 stream->Add(" (%s) ", ElementsKindToString(kind)); 330 stream->Add(" (%s) ", ElementsKindToString(kind));
332 } 331 }
333 332
334 333
335 void LAccessArgumentsAt::PrintDataTo(StringStream* stream) { 334 void LAccessArgumentsAt::PrintDataTo(StringStream* stream) {
336 arguments()->PrintTo(stream); 335 arguments()->PrintTo(stream);
337 stream->Add(" length "); 336 stream->Add(" length ");
338 length()->PrintTo(stream); 337 length()->PrintTo(stream);
339 stream->Add(" index "); 338 stream->Add(" index ");
340 index()->PrintTo(stream); 339 index()->PrintTo(stream);
(...skipping 2295 matching lines...) Expand 10 before | Expand all | Expand 10 after
2636 2635
2637 2636
2638 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2637 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2639 LOperand* object = UseRegister(instr->object()); 2638 LOperand* object = UseRegister(instr->object());
2640 LOperand* index = UseRegister(instr->index()); 2639 LOperand* index = UseRegister(instr->index());
2641 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2640 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2642 } 2641 }
2643 2642
2644 2643
2645 } } // namespace v8::internal 2644 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698