Issue 1709053003: Reland: service worker: use 200 OK for update requests even in the no update case

Issue 1709053003: Reland: service worker: use 200 OK for update requests even in the no update case (Closed)

Created:
4 years, 10 months ago by falken

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland: service worker: use 200 OK for update requests even in the no update case The main motivation is to stop network failure error spew in DevTools console. This patch reinstates the "pause on download" functionality we once had. Relanding after adding MAYBE_. BUG=541797

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+343 lines, -72 lines)			Patch
M	content/browser/service_worker/embedded_worker_instance.h	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	content/browser/service_worker/embedded_worker_instance.cc	View	4 chunks	+15 lines, -1 line	0 comments	Download
M	content/browser/service_worker/embedded_worker_instance_unittest.cc	View	2 chunks	+33 lines, -3 lines	0 comments	Download
M	content/browser/service_worker/embedded_worker_test_helper.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/service_worker/embedded_worker_test_helper.cc	View	3 chunks	+19 lines, -2 lines	0 comments	Download
M	content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_job_unittest.cc	View	8 chunks	+51 lines, -11 lines	0 comments	Download
M	content/browser/service_worker/service_worker_register_job.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_register_job.cc	View	8 chunks	+34 lines, -12 lines	0 comments	Download
M	content/browser/service_worker/service_worker_registration.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/service_worker/service_worker_version.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/service_worker/service_worker_version.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_version_unittest.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/service_worker/service_worker_write_to_cache_job.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/browser/service_worker/service_worker_write_to_cache_job.cc	View	3 chunks	+5 lines, -12 lines	0 comments	Download
M	content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/service_worker/embedded_worker_messages.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_dispatcher.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_dispatcher.cc	View	3 chunks	+17 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp	View	7 chunks	+23 lines, -8 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp	View	4 chunks	+72 lines, -3 lines	0 comments	Download
M	third_party/WebKit/public/web/WebEmbeddedWorker.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h	View	2 chunks	+10 lines, -2 lines	0 comments	Download