Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 170903002: MIPS: Second attempt at introducing a premonomorphic state in the call target caches. (Closed)

Created:
6 years, 10 months ago by kilvadyb
Modified:
6 years, 10 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Second attempt at introducing a premonomorphic state in the call target caches. Port: r19457 (9d8d5f3) Original commit message: This time we don't go through the premonomorphic state for the Array call target caches to avoid losing information from allocation sites that aren't only used once, but where the resulting array is used heavily. Patch from Kasper Lund <kasperl@chromium.org>;. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -30 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +42 lines, -30 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 10 months ago (2014-02-18 18:01:08 UTC) #1
Paul Lind
lgtm https://codereview.chromium.org/170903002/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/170903002/diff/1/src/mips/code-stubs-mips.cc#newcode3200 src/mips/code-stubs-mips.cc:3200: __ Branch(USE_DELAY_SLOT, &done); +1 for delay slot filling. ...
6 years, 10 months ago (2014-02-18 19:19:54 UTC) #2
Paul Lind
6 years, 10 months ago (2014-02-18 19:35:26 UTC) #3
Committed as r19463.

Powered by Google App Engine
This is Rietveld 408576698