Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: third_party/WebKit/Source/modules/vr/VREyeParameters.cpp

Issue 1709003002: Geometry: Reimplement DOMPoint using V8 extras. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/vr/VREyeParameters.h" 5 #include "modules/vr/VREyeParameters.h"
6 6
7 #include "bindings/core/v8/GeometryInterfaces.h"
8
7 namespace blink { 9 namespace blink {
8 10
9 namespace {
10
11 void setDomPoint(DOMPoint* point, const WebVRVector3& vec)
12 {
13 point->setX(vec.x);
14 point->setY(vec.y);
15 point->setZ(vec.z);
16 point->setW(1.0);
17 }
18
19 } // namespace
20
21 VREyeParameters::VREyeParameters() 11 VREyeParameters::VREyeParameters()
22 { 12 {
23 m_minimumFieldOfView = new VRFieldOfView(); 13 m_minimumFieldOfView = new VRFieldOfView();
24 m_maximumFieldOfView = new VRFieldOfView(); 14 m_maximumFieldOfView = new VRFieldOfView();
25 m_recommendedFieldOfView = new VRFieldOfView(); 15 m_recommendedFieldOfView = new VRFieldOfView();
26 m_eyeTranslation = DOMPoint::create(0, 0, 0, 0); 16 m_eyeTranslation = GeometryInterfaces::createDOMPoint(0, 0, 0, 0);
27 17
28 m_currentFieldOfView = new VRFieldOfView(); 18 m_currentFieldOfView = new VRFieldOfView();
29 m_renderRect = DOMRect::create(0, 0, 0, 0); 19 m_renderRect = DOMRect::create(0, 0, 0, 0);
30 } 20 }
31 21
32 void VREyeParameters::setFromWebVREyeParameters(const WebVREyeParameters &state) 22 void VREyeParameters::setFromWebVREyeParameters(const WebVREyeParameters &state)
33 { 23 {
34 // FIXME: We should expose proper min/max FOV eventually but for now set the 24 // FIXME: We should expose proper min/max FOV eventually but for now set the
35 // min/max equal to the recommended FOV to reduce need for synchronous 25 // min/max equal to the recommended FOV to reduce need for synchronous
36 // queries and reduce rendering complexity. 26 // queries and reduce rendering complexity.
37 m_minimumFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView); 27 m_minimumFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView);
38 m_maximumFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView); 28 m_maximumFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView);
39 m_recommendedFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfVi ew); 29 m_recommendedFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfVi ew);
40 setDomPoint(m_eyeTranslation, state.eyeTranslation); 30 GeometryInterfaces::updateDOMPoint(m_eyeTranslation,
31 state.eyeTranslation.x,
32 state.eyeTranslation.y,
33 state.eyeTranslation.z);
41 34
42 m_currentFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView); 35 m_currentFieldOfView->setFromWebVRFieldOfView(state.recommendedFieldOfView);
43 m_renderRect = DOMRect::create(state.renderRect.x, state.renderRect.y, state .renderRect.width, state.renderRect.height); 36 m_renderRect = DOMRect::create(state.renderRect.x, state.renderRect.y, state .renderRect.width, state.renderRect.height);
44 } 37 }
45 38
46 DEFINE_TRACE(VREyeParameters) 39 DEFINE_TRACE(VREyeParameters)
47 { 40 {
48 visitor->trace(m_minimumFieldOfView); 41 visitor->trace(m_minimumFieldOfView);
49 visitor->trace(m_maximumFieldOfView); 42 visitor->trace(m_maximumFieldOfView);
50 visitor->trace(m_recommendedFieldOfView); 43 visitor->trace(m_recommendedFieldOfView);
51 visitor->trace(m_eyeTranslation);
52 visitor->trace(m_currentFieldOfView); 44 visitor->trace(m_currentFieldOfView);
53 visitor->trace(m_renderRect); 45 visitor->trace(m_renderRect);
54 } 46 }
55 47
56 } // namespace blink 48 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698