gpu/command_buffer/service/buffer_manager.cc - Issue 1708983002: Command buffer: Fix bugs for drawing when the type of vertex attrib is a packed type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/buffer_manager.cc

Issue 1708983002: Command buffer: Fix bugs for drawing when the type of vertex attrib is a packed type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed zmo@'s feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/common/gles2_cmd_utils.cc ('K') | « gpu/command_buffer/common/gles2_cmd_utils.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/buffer_manager.cc

diff --git a/gpu/command_buffer/service/buffer_manager.cc b/gpu/command_buffer/service/buffer_manager.cc

index 498185facc54e3c11f1472154d0136f62614e189..914d9b09da06e8fb3a71c2162e9a8e6291dea962 100644

--- a/gpu/command_buffer/service/buffer_manager.cc

+++ b/gpu/command_buffer/service/buffer_manager.cc

@@ -223,7 +223,7 @@ bool Buffer::GetMaxValueForRange(

uint32_t size;

if (!SafeMultiplyUint32(

- count, GLES2Util::GetGLTypeSizeForTexturesAndBuffers(type), &size)) {

+ count, GLES2Util::GetGLTypeSizeForBuffers(type), &size)) {

return false;

}