gpu/command_buffer/common/gles2_cmd_utils.h - Issue 1708983002: Command buffer: Fix bugs for drawing when the type of vertex attrib is a packed type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/common/gles2_cmd_utils.h

Issue 1708983002: Command buffer: Fix bugs for drawing when the type of vertex attrib is a packed type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed zmo@'s feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/client/vertex_array_object_manager.cc ('k') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('j') | gpu/command_buffer/common/gles2_cmd_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/common/gles2_cmd_utils.h

diff --git a/gpu/command_buffer/common/gles2_cmd_utils.h b/gpu/command_buffer/common/gles2_cmd_utils.h

index 848abcaea5ed264e3d2c09826ee8a44286fb2e2c..3c302af9bedcfa95e72e8d283c3e4eae25c425c5 100644

--- a/gpu/command_buffer/common/gles2_cmd_utils.h

+++ b/gpu/command_buffer/common/gles2_cmd_utils.h

@@ -155,7 +155,9 @@ class GLES2_UTILS_EXPORT GLES2Util {

// For example, GL_FLOAT_MAT3 returns 9.

static uint32_t GetElementCountForUniformType(int type);

- static size_t GetGLTypeSizeForTexturesAndBuffers(uint32_t type);

+ static size_t GetGLTypeSizeForBuffers(uint32_t type);

+ static size_t GetGroupSizeForBufferType(uint32_t count, uint32_t type);

static size_t GetGLTypeSizeForPathCoordType(uint32_t type);