Command buffer: Fix bugs for drawing when the type of vertex attrib is a packed type

gpu/command_buffer/common/gles2_cmd_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is here so other GLES2 related files can have a common set of
 // includes where appropriate.
 
 #include <sstream>
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 777 matching lines @@
       return 8;
     case GL_FLOAT_MAT3x4:
     case GL_FLOAT_MAT4x3:
       return 12;
 
     default:
       return 0;
   }
 }
 
-size_t GLES2Util::GetGLTypeSizeForTexturesAndBuffers(uint32_t type) {
+size_t GLES2Util::GetGLTypeSizeForBuffers(uint32_t type) {
   switch (type) {
     case GL_BYTE:
       return sizeof(GLbyte);  // NOLINT
     case GL_UNSIGNED_BYTE:
       return sizeof(GLubyte);  // NOLINT
     case GL_SHORT:
       return sizeof(GLshort);  // NOLINT
     case GL_UNSIGNED_SHORT:
       return sizeof(GLushort);  // NOLINT
     case GL_INT:
       return sizeof(GLint);  // NOLINT
     case GL_UNSIGNED_INT:
       return sizeof(GLuint);  // NOLINT
     case GL_FLOAT:
       return sizeof(GLfloat);  // NOLINT
     case GL_FIXED:
       return sizeof(GLfixed);  // NOLINT
     case GL_HALF_FLOAT:
       return sizeof(GLushort);  // NOLINT
     case GL_INT_2_10_10_10_REV:
       return sizeof(GLint);  // NOLINT
     case GL_UNSIGNED_INT_2_10_10_10_REV:
       return sizeof(GLuint);  // NOLINT
     default:
       return 0;
   }
 }
 
+size_t GLES2Util::GetGroupSizeForBufferType(uint32_t count, uint32_t type) {
+  size_t type_size = GetGLTypeSizeForBuffers(type);
+  // For packed types, group size equals to the type size.
+  if (type == GL_INT_2_10_10_10_REV || type == GL_UNSIGNED_INT_2_10_10_10_REV)
+    return type_size;

[Zhenyao Mo, 2016/02/26 04:24:29]

nit: please DCHECK_EQ(4u, count) here.

[yunchao, 2016/02/26 06:45:26]

Done.

+  return type_size * count;
+}
 size_t GLES2Util::GetComponentCountForGLTransformType(uint32_t type) {
   switch (type) {
     case GL_TRANSLATE_X_CHROMIUM:
     case GL_TRANSLATE_Y_CHROMIUM:
       return 1;
     case GL_TRANSLATE_2D_CHROMIUM:
       return 2;
     case GL_TRANSLATE_3D_CHROMIUM:
       return 3;
     case GL_AFFINE_2D_CHROMIUM:
@@ skipping 680 matching lines @@
   }
 
   return true;
 }
 
 #include "gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu