Ensure ADTS for AAC for MediaCodecAudioDecoder

Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.

BUG=542910
Committed: https://crrev.com/e8b64f7cd9ea8333d217e8662f66cc7889da2c32
Cr-Commit-Position: refs/heads/master@{#376222}

[Tima Vaisburd, 2016-02-18 02:58:56]

Description was changed from

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

BUG=542910
==========

to

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.
  
BUG=542910
==========

[Tima Vaisburd, 2016-02-18 02:59:51]

timav@chromium.org changed reviewers:
+ dalecurtis@chromium.org, xhwang@chromium.org

[Tima Vaisburd, 2016-02-18 02:59:51]

PTAL

[DaleCurtis, 2016-02-18 04:04:37]

I don't think the Mojo framework we have right now will support this, but for
testing with --no-sandbox and your audio decoder this lgtm

https://codereview.chromium.org/1708963002/diff/1/media/base/audio_decoder.h
File media/base/audio_decoder.h (right):

https://codereview.chromium.org/1708963002/diff/1/media/base/audio_decoder.h#...
media/base/audio_decoder.h:89: virtual bool NeedsBitstreamConversion() const;
Hmm, interface used to be pure virtual up to this point, but this is how
VideoDecoder does it so this change is fine with me.

[xhwang, 2016-02-18 05:14:10]

Dalecurtis: MojoAudioDecoder doesn't exist yet. When we implement it we'll plumb
through this information.

LGTM!

[Tima Vaisburd, 2016-02-18 17:53:31]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-02-18 17:56:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708963002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708963002/1

[commit-bot: I haz the power, 2016-02-18 19:16:45]

Description was changed from

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.
  
BUG=542910
==========

to

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.
  
BUG=542910
==========

[commit-bot: I haz the power, 2016-02-18 19:16:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 19:18:21]

Description was changed from

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.
  
BUG=542910
==========

to

==========
Ensure ADTS for AAC for MediaCodecAudioDecoder

The MediaCodecBridge always sets the AAC audio stream as ADTS
(Audio Data Transport Stream). We make MediaCodecAudioDecoder
request ADTS for AAC streams.

This CL adds new method NeedsBitstreamConversion() to the
AudioDecoder interface and uses it in the DecoderStreamTraits.

BUG=542910

Committed: https://crrev.com/e8b64f7cd9ea8333d217e8662f66cc7889da2c32
Cr-Commit-Position: refs/heads/master@{#376222}
==========

[commit-bot: I haz the power, 2016-02-18 19:18:22]

Patchset 1 (id:??) landed as
https://crrev.com/e8b64f7cd9ea8333d217e8662f66cc7889da2c32
Cr-Commit-Position: refs/heads/master@{#376222}