Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1708953002: Fix a logical race when adding an awakable to a wait set. (Closed)

Created:
4 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a logical race when adding an awakable to a wait set. If the wait set is being woken on one thread and have an awakable added on another (i.e. during MojoWait on the wait set), it is possible for the awakable to be added after checking the signals state, but before adding to the awakables list. In this case, the added awakable won't get woken up. The fix is to ensure that checking the signals state and adding to the awakables list is an atomic operation. Committed: https://crrev.com/e388b5966b6a02215e744269b7add8e7e36a6a0c Cr-Commit-Position: refs/heads/master@{#376089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M mojo/edk/system/wait_set_dispatcher.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 10 months ago (2016-02-18 01:50:08 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-18 03:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708953002/1
4 years, 10 months ago (2016-02-18 03:42:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 04:18:43 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 04:20:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e388b5966b6a02215e744269b7add8e7e36a6a0c
Cr-Commit-Position: refs/heads/master@{#376089}

Powered by Google App Engine
This is Rietveld 408576698