Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1708913002: Check null intent when launching DownloadNotificationService (Closed)

Created:
4 years, 10 months ago by qinmin
Modified:
4 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check null intent when launching DownloadNotificationService When onStartCommand() is called, it is possible that the intent is null. According to the SDK page, service must take care of the null check. BUG=587399 Committed: https://crrev.com/8728e6c1c0806f8f0a2476e4c19087d9c4b36786 Cr-Commit-Position: refs/heads/master@{#376048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 10 months ago (2016-02-17 23:23:08 UTC) #2
Ted C
lgtm
4 years, 10 months ago (2016-02-17 23:29:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708913002/1
4 years, 10 months ago (2016-02-17 23:30:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 00:26:56 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 00:28:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8728e6c1c0806f8f0a2476e4c19087d9c4b36786
Cr-Commit-Position: refs/heads/master@{#376048}

Powered by Google App Engine
This is Rietveld 408576698