Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Side by Side Diff: src/mips/stub-cache-mips.cc

Issue 17088008: MIPS: Fix constant function transition. Insert return instruction before returning. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 // name_reg as scratch register. 559 // name_reg as scratch register.
560 __ RecordWriteField(receiver_reg, 560 __ RecordWriteField(receiver_reg,
561 HeapObject::kMapOffset, 561 HeapObject::kMapOffset,
562 scratch1, 562 scratch1,
563 scratch2, 563 scratch2,
564 kRAHasNotBeenSaved, 564 kRAHasNotBeenSaved,
565 kDontSaveFPRegs, 565 kDontSaveFPRegs,
566 OMIT_REMEMBERED_SET, 566 OMIT_REMEMBERED_SET,
567 OMIT_SMI_CHECK); 567 OMIT_SMI_CHECK);
568 568
569 if (details.type() == CONSTANT_FUNCTION) return; 569 if (details.type() == CONSTANT_FUNCTION) {
570 ASSERT(value_reg.is(a0));
571 __ Ret(USE_DELAY_SLOT);
572 __ mov(v0, a0);
573 return;
574 }
570 575
571 int index = transition->instance_descriptors()->GetFieldIndex( 576 int index = transition->instance_descriptors()->GetFieldIndex(
572 transition->LastAdded()); 577 transition->LastAdded());
573 578
574 // Adjust for the number of properties stored in the object. Even in the 579 // Adjust for the number of properties stored in the object. Even in the
575 // face of a transition we can use the old map here because the size of the 580 // face of a transition we can use the old map here because the size of the
576 // object and the number of in-object properties is not going to change. 581 // object and the number of in-object properties is not going to change.
577 index -= object->map()->inobject_properties(); 582 index -= object->map()->inobject_properties();
578 583
579 // TODO(verwaest): Share this code as a code stub. 584 // TODO(verwaest): Share this code as a code stub.
(...skipping 3193 matching lines...) Expand 10 before | Expand all | Expand 10 after
3773 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3778 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3774 } 3779 }
3775 } 3780 }
3776 3781
3777 3782
3778 #undef __ 3783 #undef __
3779 3784
3780 } } // namespace v8::internal 3785 } } // namespace v8::internal
3781 3786
3782 #endif // V8_TARGET_ARCH_MIPS 3787 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698