Mustash: move content::GPUVideoMemoryUsageStats to gpu::VideoMemoryUsageStats

Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}

Committed: https://crrev.com/cbf36ceafceb140cdc5d6f45a9ae2053483795c4
Cr-Commit-Position: refs/heads/master@{#378757}

[Mark Dittmer, 2016-02-17 20:33:55]

Description was changed from

==========
WIP: Move content:GPUVideo...Stats to gpu::Video...Stats

BUG=586367
==========

to

==========
WIP: Move content:GPUVideo...Stats to gpu::Video...Stats

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Mark Dittmer, 2016-02-18 16:04:14]

Description was changed from

==========
WIP: Move content:GPUVideo...Stats to gpu::Video...Stats

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-02-18 16:07:10]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-02-18 16:07:11]

Looks reasonable to me, please update the title.

[Mark Dittmer, 2016-02-18 16:09:07]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Mark Dittmer, 2016-02-18 16:09:21]

markdittmer@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-02-18 18:11:45]

gpu/config is a bit odd, since that has to do with the GPU blacklist/workaround
list processing, and would apply in a single-process mode too. The memory stats
are about the mapping of tracked memory to process id... how about moving it to
gpu/ipc/common ?

[Mark Dittmer, 2016-02-18 21:14:37]

On 2016/02/18 18:11:45, piman wrote:
> gpu/config is a bit odd, since that has to do with the GPU
blacklist/workaround
> list processing, and would apply in a single-process mode too. The memory
stats
> are about the mapping of tracked memory to process id... how about moving it
to
> gpu/ipc/common ?

Can do. Will post new patch tomorrow morning (EST).

[Mark Dittmer, 2016-02-19 22:35:11]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 22:40:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/40001

[commit-bot: I haz the power, 2016-02-19 22:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 22:40:48]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Fady Samuel, 2016-02-20 04:16:18]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-20 04:16:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/40001

[commit-bot: I haz the power, 2016-02-20 04:20:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 04:20:24]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Mark Dittmer, 2016-02-22 14:14:14]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 14:14:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/60001

[commit-bot: I haz the power, 2016-02-22 14:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 14:14:26]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Mark Dittmer, 2016-02-22 15:53:33]

On 2016/02/18 21:14:37, Mark Dittmer wrote:
> On 2016/02/18 18:11:45, piman wrote:
> > gpu/config is a bit odd, since that has to do with the GPU
> blacklist/workaround
> > list processing, and would apply in a single-process mode too. The memory
> stats
> > are about the mapping of tracked memory to process id... how about moving it
> to
> > gpu/ipc/common ?
> 
> Can do. Will post new patch tomorrow morning (EST).

Refactor posted. piman@ PTAL.

[piman, 2016-02-22 19:10:05]

https://codereview.chromium.org/1708783002/diff/60001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1708783002/diff/60001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:3494: 'dependencies': [ '../gpu/gpu.gyp:gpu_config'
],
gpu_ipc_common?

[Mark Dittmer, 2016-02-22 19:21:07]

https://codereview.chromium.org/1708783002/diff/60001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1708783002/diff/60001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:3494: 'dependencies': [ '../gpu/gpu.gyp:gpu_config'
],
On 2016/02/22 19:10:05, piman wrote:
> gpu_ipc_common?

Done.

[piman, 2016-02-22 20:19:49]

lgtm

[Mark Dittmer, 2016-02-22 21:42:00]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2016-02-22 21:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/80001

[commit-bot: I haz the power, 2016-02-22 22:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 22:08:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Dittmer, 2016-02-23 13:27:03]

markdittmer@chromium.org changed reviewers:
+ jam@chromium.org

[Mark Dittmer, 2016-02-23 13:29:30]

markdittmer@chromium.org changed reviewers:
+ kenrb@chromium.org

[Mark Dittmer, 2016-02-23 14:45:51]

On 2016/02/22 22:08:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

+jam, +kenrb for owners review. PTAL.

[kenrb, 2016-02-23 14:59:15]

ipc lgtm

[Mark Dittmer, 2016-02-23 16:33:53]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jam, 2016-02-23 16:48:25]

lgtm

[Mark Dittmer, 2016-02-23 16:49:24]

The CQ bit was checked by markdittmer@chromium.org

[commit-bot: I haz the power, 2016-02-23 16:50:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/80001

[commit-bot: I haz the power, 2016-02-23 19:16:18]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-02-23 19:16:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-23 19:18:04]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

[commit-bot: I haz the power, 2016-02-23 19:18:05]

Patchset 5 (id:??) landed as
https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}

[Nico, 2016-02-24 01:59:13]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-02-24 01:59:14]

I believe this broke component builds with gn, at least on Windows. See
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/buil...
for build errors.

[Nico, 2016-02-24 15:06:57]

Hey, this broke the main waterfall gn bots too, I guess sheriffs just didn't
notice. Reverting.

[Nico, 2016-02-24 15:08:44]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1726343003/ by thakis@chromium.org.

The reason for reverting is: Doesn't build on win/gn bots:
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29...

FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper
environment.x64 False link.exe /nologo /IMPLIB:./content.dll.lib /DLL
/OUT:./content.dll /PDB:./content.dll.pdb @./content.dll.rsp
gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::VideoMemoryUsageStats::VideoMemoryUsageStats(void)"
(??0VideoMemoryUsageStats@gpu@@QEAA@XZ) already defined in memory_stats.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::VideoMemoryUsageStats::~VideoMemoryUsageStats(void)"
(??1VideoMemoryUsageStats@gpu@@QEAA@XZ) already defined in memory_stats.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::VideoMemoryUsageStats::ProcessStats::ProcessStats(void)"
(??0ProcessStats@VideoMemoryUsageStats@gpu@@QEAA@XZ) already defined in
memory_stats.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::VideoMemoryUsageStats::ProcessStats::~ProcessStats(void)"
(??1ProcessStats@VideoMemoryUsageStats@gpu@@QEAA@XZ) already defined in
memory_stats.obj

gpu.dll.lib(gpu.dll) : error LNK2005: "public: __cdecl
gpu::VideoMemoryUsageStats::VideoMemoryUsageStats(struct
gpu::VideoMemoryUsageStats const &)"
(??0VideoMemoryUsageStats@gpu@@QEAA@AEBU01@@Z) already defined in
memory_stats.obj

./content.dll : fatal error LNK1169: one or more multiply defined symbols found.

[Nico, 2016-02-24 15:15:17]

https://codereview.chromium.org/1708783002/diff/80001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (right):

https://codereview.chromium.org/1708783002/diff/80001/content/gpu/BUILD.gn#ne...
content/gpu/BUILD.gn:47: "//gpu/ipc/common:ipc_common_sources",
This looks really questionable. ipc_common_sources sets GPU_IMPLEMENTATION, so
it'll export all its things – so it must only be linked into the gpu component.
This adds it to the content component too, and then exports them too.

Arguably things are even worse in the gyp build as far as I can tell:
gpu_ipc_common is a static_library but doesn't set GPU_IMPLEMENTATION, so all
the GPU_EXPORTs in that target are effectively ignored and the static library is
linked into many components.

The way this should work is one of these two things:

1. Export these classes only from gpu, which means depending on
ipc_common_sources _only_ from the gpu target

2. Make ipc_common_sources its own component with its own _EXPORT macro.

I don't know what you're trying to do so I can't recommend which of these is
right for you (generally, I'd guess 2). I'm happy to review this part in a fixed
patch set or advise on this (but your original reviewers will be able to do this
too)

[Mark Dittmer, 2016-02-25 15:29:36]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

[Mark Dittmer, 2016-02-25 16:06:53]

https://codereview.chromium.org/1708783002/diff/80001/content/gpu/BUILD.gn
File content/gpu/BUILD.gn (right):

https://codereview.chromium.org/1708783002/diff/80001/content/gpu/BUILD.gn#ne...
content/gpu/BUILD.gn:47: "//gpu/ipc/common:ipc_common_sources",
On 2016/02/24 15:15:17, Nico wrote:
> This looks really questionable. ipc_common_sources sets GPU_IMPLEMENTATION, so
> it'll export all its things – so it must only be linked into the gpu
component.
> This adds it to the content component too, and then exports them too.
> 
> Arguably things are even worse in the gyp build as far as I can tell:
> gpu_ipc_common is a static_library but doesn't set GPU_IMPLEMENTATION, so all
> the GPU_EXPORTs in that target are effectively ignored and the static library
is
> linked into many components.
> 
> The way this should work is one of these two things:
> 
> 1. Export these classes only from gpu, which means depending on
> ipc_common_sources _only_ from the gpu target
> 
> 2. Make ipc_common_sources its own component with its own _EXPORT macro.
> 
> I don't know what you're trying to do so I can't recommend which of these is
> right for you (generally, I'd guess 2). I'm happy to review this part in a
fixed
> patch set or advise on this (but your original reviewers will be able to do
this
> too)

Thanks for the thorough feedback! Based on how much more we anticipate putting
in ipc/common I think I'll implement 1. Will ping when updated gn/gyp files are
ready.

[Mark Dittmer, 2016-02-25 18:27:37]

Fix up build deps

[Mark Dittmer, 2016-02-25 18:27:50]

Uploaded fix of dependencies. thakis@ PTAL.

[Fady Samuel, 2016-02-25 18:29:23]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 18:30:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/100001

[Nico, 2016-02-25 18:39:13]

lgtm, thanks!

If you want, you can send a try job to win_clang_x64_dbg, that does component
builds with gn. (The bot is currently red due to someone else breaking it, but
it should hopefully cycle green once https://codereview.chromium.org/1731793008/
is in)

[commit-bot: I haz the power, 2016-02-25 18:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 18:45:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Mark Dittmer, 2016-03-02 14:23:50]

rebase

[Mark Dittmer, 2016-03-02 14:24:06]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 14:24:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/120001

[commit-bot: I haz the power, 2016-03-02 15:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 15:42:36]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-02 16:02:52]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-02 16:02:52]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
jam@chromium.org, piman@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1708783002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-02 16:03:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708783002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708783002/120001

[commit-bot: I haz the power, 2016-03-02 16:08:36]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

[commit-bot: I haz the power, 2016-03-02 16:08:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-02 16:10:09]

Description was changed from

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}
==========

to

==========
Move content:GPUVideo...Stats to gpu::Video...Stats. HolyJavaStyleNamingBatman!

As a part of the GPU refactor for Mus, we are trying to eliminate spots where
content/common/gpu depends on
content/. One such dependency is content::GPUVideoMemoryUsageStats.

BUG=586367
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6c1a70a5d0436c7c647c995202fbfa307f28983a
Cr-Commit-Position: refs/heads/master@{#377036}

Committed: https://crrev.com/cbf36ceafceb140cdc5d6f45a9ae2053483795c4
Cr-Commit-Position: refs/heads/master@{#378757}
==========

[commit-bot: I haz the power, 2016-03-02 16:10:10]

Patchset 7 (id:??) landed as
https://crrev.com/cbf36ceafceb140cdc5d6f45a9ae2053483795c4
Cr-Commit-Position: refs/heads/master@{#378757}