TaskScheduler [7] SchedulerThreadPool

base/task_scheduler/utils_unittest.cc

Index: base/task_scheduler/utils_unittest.cc
diff --git a/base/task_scheduler/utils_unittest.cc b/base/task_scheduler/utils_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..29d911a36da866cdb9bdb688996029307b32a861
--- /dev/null
+++ b/base/task_scheduler/utils_unittest.cc
@@ -0,0 +1,124 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/utils.h"
+
+#include <memory>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback.h"
+#include "base/memory/ptr_util.h"
+#include "base/memory/ref_counted.h"
+#include "base/task_scheduler/priority_queue.h"
+#include "base/task_scheduler/scheduler_task_executor.h"
+#include "base/task_scheduler/sequence.h"
+#include "base/task_scheduler/task.h"
+#include "base/task_scheduler/task_tracker.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+
+bool operator==(const Closure& lhs, const Closure& rhs) {
+  return lhs.Equals(rhs);
+}
+
+namespace internal {
+namespace {
+
+class MockSchedulerTaskExecutor : public SchedulerTaskExecutor {
+ public:
+  void PostTaskWithSequence(std::unique_ptr<Task> task,
+                            scoped_refptr<Sequence> sequence) override {
+    PostTaskWithSequenceMock(task->task, task->traits, sequence.get());
+  }
+
+  MOCK_METHOD3(PostTaskWithSequenceMock,
+               void(const Closure&, const TaskTraits&, Sequence* sequence));
+};
+
+// Verifies that when PostTaskHelper receives a Task that is allowed to be
+// posted, it forwards it to a SchedulerTaskExecutor.
+TEST(TaskSchedulerPostTaskHelperTest, PostTaskAllowed) {
+  const Closure closure(Bind(&DoNothing));
+  const TaskTraits traits;
+  scoped_refptr<Sequence> sequence(new Sequence);
+  testing::StrictMock<MockSchedulerTaskExecutor> executor;
+  TaskTracker task_tracker;
+
+  EXPECT_CALL(executor,
+              PostTaskWithSequenceMock(closure, traits, sequence.get()));
+  PostTaskHelper(FROM_HERE, closure, traits, TimeDelta(), sequence, &executor,
+                 &task_tracker);
+}
+
+// Verifies that when PostTaskHelper receives a Task that isn't allowed to be
+// posted, it doesn't forward it to a SchedulerTaskExecutor.
+TEST(TaskSchedulerPostTaskHelperTest, PostTaskNotAllowed) {
+  testing::StrictMock<MockSchedulerTaskExecutor> executor;
+  TaskTracker task_tracker;
+  task_tracker.Shutdown();
+
+  PostTaskHelper(
+      FROM_HERE, Bind(&DoNothing),
+      TaskTraits().WithShutdownBehavior(TaskShutdownBehavior::SKIP_ON_SHUTDOWN),
+      TimeDelta(), make_scoped_refptr(new Sequence), &executor, &task_tracker);
+}

[gab, 2016/04/14 19:34:16]

Explicitly VerifyAndClear strict mock at the end? It wasn't initially clear to
me how the lack of a call was being verified.

[fdoray, 2016/04/14 23:46:59]

Adding VerifyAndClear isn't useful since it's already called when the mock
object is destroyed. Added a comment instead.

+
+// Verifies that when PostTaskWithSequenceHelper is called with an empty
+// sequence, the task is added to the sequence and the sequence is added to the
+// priority queue.
+TEST(TaskSchedulerPostTaskWithSequenceHelperTest, PostTaskInEmptySequence) {
+  std::unique_ptr<Task> task(
+      new Task(FROM_HERE, Bind(&DoNothing), TaskTraits()));
+  const Task* task_raw = task.get();
+  scoped_refptr<Sequence> sequence(new Sequence);
+  PriorityQueue priority_queue;
+
+  // Post |task|.
+  EXPECT_TRUE(
+      PostTaskWithSequenceHelper(std::move(task), sequence, &priority_queue));
+
+  // Expect to find the sequence in the priority queue.
+  EXPECT_EQ(sequence, priority_queue.BeginTransaction()->Peek().sequence);
+
+  // Expect to find |task| alone in |sequence|.
+  EXPECT_EQ(task_raw, sequence->PeekTask());
+  sequence->PopTask();
+  EXPECT_EQ(nullptr, sequence->PeekTask());
+}
+
+// Verifies that when PostTaskWithSequenceHelper is called with a sequence that
+// already contains a task, the task is added to the sequence but the sequence
+// is not added to the priority queue.
+TEST(TaskSchedulerPostTaskWithSequenceHelperTest, PostTaskInNonEmptySequence) {
+  std::unique_ptr<Task> task(
+      new Task(FROM_HERE, Bind(&DoNothing), TaskTraits()));
+  const Task* task_raw = task.get();
+  scoped_refptr<Sequence> sequence(new Sequence);
+  PriorityQueue priority_queue;
+
+  // Add an initial task in |sequence|.
+  sequence->PushTask(
+      WrapUnique(new Task(FROM_HERE, Bind(&DoNothing), TaskTraits())));
+
+  // Post |task|.
+  EXPECT_FALSE(
+      PostTaskWithSequenceHelper(std::move(task), sequence, &priority_queue));
+
+  // Expect to find the priority queue empty.
+  EXPECT_TRUE(priority_queue.BeginTransaction()->Peek().is_null());
+
+  // Expect to find |task| in |sequence| behind the initial task.
+  EXPECT_NE(task_raw, sequence->PeekTask());
+  sequence->PopTask();
+  EXPECT_EQ(task_raw, sequence->PeekTask());
+  sequence->PopTask();
+  EXPECT_EQ(nullptr, sequence->PeekTask());
+}
+
+}  // namespace
+}  // namespace internal
+}  // namespace base