Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: base/task_scheduler/scheduler_thread_pool_unittest.cc

Issue 1708773002: TaskScheduler [7] SchedulerThreadPool (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@s_5_worker_thread
Patch Set: self review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_thread_pool_unittest.cc
diff --git a/base/task_scheduler/scheduler_thread_pool_unittest.cc b/base/task_scheduler/scheduler_thread_pool_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f390f1e9f7a5c3bc899b662dfaaa49617e798943
--- /dev/null
+++ b/base/task_scheduler/scheduler_thread_pool_unittest.cc
@@ -0,0 +1,307 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/scheduler_thread_pool.h"
+
+#include <stddef.h>
+
+#include <memory>
+#include <unordered_set>
+#include <vector>
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/memory/ref_counted.h"
+#include "base/synchronization/condition_variable.h"
+#include "base/synchronization/lock.h"
+#include "base/synchronization/waitable_event.h"
+#include "base/task_runner.h"
+#include "base/task_scheduler/sequence.h"
+#include "base/task_scheduler/sequence_sort_key.h"
+#include "base/task_scheduler/task_tracker.h"
+#include "base/threading/platform_thread.h"
+#include "base/threading/simple_thread.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace base {
+namespace internal {
+namespace {
+
+const size_t kNumThreadsInThreadPool = 4;
+const size_t kNumThreadsPostingTasks = 4;
+const size_t kNumTasksPostedPerThread = 150;
+
+class TaskSchedulerThreadPoolTest : public testing::Test {
+ protected:
+ TaskSchedulerThreadPoolTest() = default;
+
+ void SetUp() override {
+ thread_pool_ = SchedulerThreadPool::CreateThreadPool(
+ ThreadPriority::NORMAL, kNumThreadsInThreadPool,
+ Bind(&TaskSchedulerThreadPoolTest::EnqueueSequenceCallback,
+ Unretained(this)),
+ &task_tracker_);
+ ASSERT_TRUE(thread_pool_);
+ }
+
+ void TearDown() override {
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+ thread_pool_->JoinForTesting();
+ }
+
+ std::unique_ptr<SchedulerThreadPool> thread_pool_;
+
+ private:
+ void EnqueueSequenceCallback(scoped_refptr<Sequence> sequence) {
+ // In production code, this callback would be implemented by the
+ // TaskScheduler which would first determine which PriorityQueue the
+ // sequence must be reinserted.
+ const SequenceSortKey sort_key(sequence->GetSortKey());
+ thread_pool_->EnqueueSequence(std::move(sequence), sort_key);
+ }
+
+ TaskTracker task_tracker_;
+
+ DISALLOW_COPY_AND_ASSIGN(TaskSchedulerThreadPoolTest);
+};
+
+class TaskFactory {
+ public:
+ TaskFactory() : cv_(&lock_) {}
+
+ // Posts a task through |task_runner|. If |post_nested_task| is true, the task
+ // will post a new task through |task_runner| when it runs. If |event| is set,
+ // the task will block until it is signaled.
+ void PostTestTask(scoped_refptr<TaskRunner> task_runner,
+ bool post_nested_task,
+ WaitableEvent* event) {
+ AutoLock auto_lock(lock_);
+ EXPECT_TRUE(task_runner->PostTask(
+ FROM_HERE, Bind(&TaskFactory::RunTaskCallback, Unretained(this),
+ num_created_tasks_++, task_runner, post_nested_task,
+ Unretained(event))));
+ }
+
+ // Waits for all tasks posted by PostTestTask() to start running. It is not
+ // guaranteed that the tasks have completed their execution when this returns.
+ void WaitForAllTasksToRun() const {
+ AutoLock auto_lock(lock_);
+ while (ran_tasks_.size() < num_created_tasks_)
+ cv_.Wait();
+ }
+
+ size_t NumRunTasks() const {
+ AutoLock auto_lock(lock_);
+ return ran_tasks_.size();
+ }
+
+ private:
+ void RunTaskCallback(size_t task_index,
+ scoped_refptr<TaskRunner> task_runner,
+ bool post_nested_task,
+ WaitableEvent* event) {
+ if (post_nested_task)
+ PostTestTask(task_runner, false, nullptr);
+
+ EXPECT_TRUE(task_runner->RunsTasksOnCurrentThread());
+
+ {
+ AutoLock auto_lock(lock_);
+
+ if (ran_tasks_.find(task_index) != ran_tasks_.end())
+ ADD_FAILURE() << "A task ran more than once.";
+ ran_tasks_.insert(task_index);
+
+ cv_.Signal();
+ }
+
+ if (event)
+ event->Wait();
+ }
+
+ // Synchronizes access to all members below.
+ mutable Lock lock_;
+
+ // Condition variable signaled when a task runs.
+ mutable ConditionVariable cv_;
+
+ // Number of tasks posted by PostTestTask().
+ size_t num_created_tasks_ = 0;
+
+ // Indexes of tasks that ran.
+ std::unordered_set<size_t> ran_tasks_;
+
+ DISALLOW_COPY_AND_ASSIGN(TaskFactory);
+};
+
+class ThreadPostingTasks : public SimpleThread {
+ public:
+ // Constructs a thread that posts tasks to |thread_pool| through an
+ // |execution_mode| task runner. If |wait_for_all_threads_idle| is true, the
+ // thread wait until all worker threads in |thread_pool| are idle before
+ // posting a new task. If |post_nested_task| is true, each task posted by this
+ // thread posts another task when it runs.
+ ThreadPostingTasks(SchedulerThreadPool* thread_pool,
+ ExecutionMode execution_mode,
+ bool wait_for_all_threads_idle,
+ bool post_nested_task)
+ : SimpleThread("ThreadPostingTasks"),
+ thread_pool_(thread_pool),
+ task_runner_(thread_pool_->CreateTaskRunnerWithTraits(TaskTraits(),
+ execution_mode)),
+ wait_for_all_threads_idle_(wait_for_all_threads_idle),
+ post_nested_task_(post_nested_task) {
+ DCHECK(thread_pool_);
+ }
+
+ const TaskFactory* factory() const { return &factory_; }
+
+ private:
+ void Run() override {
+ EXPECT_FALSE(task_runner_->RunsTasksOnCurrentThread());
+
+ for (size_t i = 0; i < kNumTasksPostedPerThread; ++i) {
+ if (wait_for_all_threads_idle_)
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+ factory_.PostTestTask(task_runner_, post_nested_task_, nullptr);
+ }
+ }
+
+ SchedulerThreadPool* const thread_pool_;
+ const scoped_refptr<TaskRunner> task_runner_;
+ const bool wait_for_all_threads_idle_;
+ const bool post_nested_task_;
+ TaskFactory factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(ThreadPostingTasks);
+};
+
+TEST_F(TaskSchedulerThreadPoolTest, PostParallelTasks) {
+ // Create threads to post tasks to PARALLEL TaskRunners.
+ std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
+ for (size_t i = 0; i < kNumThreadsPostingTasks; ++i) {
+ const bool kWaitForAllThreadIdle = false;
+ const bool kPostNestedTasks = false;
+ threads_posting_tasks.push_back(WrapUnique(
+ new ThreadPostingTasks(thread_pool_.get(), ExecutionMode::PARALLEL,
+ kWaitForAllThreadIdle, kPostNestedTasks)));
+ threads_posting_tasks.back()->Start();
+ }
+
+ // Wait for all tasks to run.
+ for (const auto& thread_posting_tasks : threads_posting_tasks) {
+ thread_posting_tasks->Join();
+ thread_posting_tasks->factory()->WaitForAllTasksToRun();
+ EXPECT_EQ(kNumTasksPostedPerThread,
+ thread_posting_tasks->factory()->NumRunTasks());
+ }
+
+ // Wait until all worker threads are idle to be sure that no task accesses
+ // its TaskFactory after |thread_posting_tasks| is destroyed.
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+}
+
+TEST_F(TaskSchedulerThreadPoolTest, PostParallelTasksWaitAllThreadsIdle) {
+ // Create threads to post tasks to PARALLEL TaskRunners. To verify that
+ // worker threads can sleep and be woken up when new tasks are posted, wait
+ // for all threads to become idle before posting a new task.
+ std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
+ for (size_t i = 0; i < kNumThreadsPostingTasks; ++i) {
+ const bool kWaitForAllThreadIdle = true;
+ const bool kPostNestedTasks = false;
+ threads_posting_tasks.push_back(WrapUnique(
+ new ThreadPostingTasks(thread_pool_.get(), ExecutionMode::PARALLEL,
+ kWaitForAllThreadIdle, kPostNestedTasks)));
+ threads_posting_tasks.back()->Start();
+ }
+
+ // Wait for all tasks to run.
+ for (const auto& thread_posting_tasks : threads_posting_tasks) {
+ thread_posting_tasks->Join();
+ thread_posting_tasks->factory()->WaitForAllTasksToRun();
+ EXPECT_EQ(kNumTasksPostedPerThread,
+ thread_posting_tasks->factory()->NumRunTasks());
+ }
+
+ // Wait until all worker threads are idle to be sure that no task accesses
+ // its TaskFactory after |thread_posting_tasks| is destroyed.
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+}
+
+TEST_F(TaskSchedulerThreadPoolTest, NestedPostParallelTasks) {
+ // Create threads to post tasks to PARALLEL TaskRunners. Each task posted by
+ // these threads will post another task when it runs.
+ std::vector<std::unique_ptr<ThreadPostingTasks>> threads_posting_tasks;
+ for (size_t i = 0; i < kNumThreadsPostingTasks; ++i) {
+ const bool kWaitForAllThreadIdle = false;
+ const bool kPostNestedTasks = true;
+ threads_posting_tasks.push_back(WrapUnique(
+ new ThreadPostingTasks(thread_pool_.get(), ExecutionMode::PARALLEL,
+ kWaitForAllThreadIdle, kPostNestedTasks)));
+ threads_posting_tasks.back()->Start();
+ }
+
+ // Wait for all tasks to run.
+ for (const auto& thread_posting_tasks : threads_posting_tasks) {
+ thread_posting_tasks->Join();
+ thread_posting_tasks->factory()->WaitForAllTasksToRun();
+ EXPECT_EQ(2 * kNumTasksPostedPerThread,
+ thread_posting_tasks->factory()->NumRunTasks());
+ }
+
+ // Wait until all worker threads are idle to be sure that no task accesses
+ // its TaskFactory after |thread_posting_tasks| is destroyed.
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+}
+
+TEST_F(TaskSchedulerThreadPoolTest, PostParallelTasksWithOneAvailableThread) {
+ TaskFactory factory;
+
+ // Post tasks to keep all threads busy except one until |event| is signaled.
+ WaitableEvent event(true, false);
+ auto task_runner = thread_pool_->CreateTaskRunnerWithTraits(
+ TaskTraits(), ExecutionMode::PARALLEL);
+ for (size_t i = 0; i < (kNumThreadsInThreadPool - 1); ++i)
+ factory.PostTestTask(task_runner, false, &event);
+ factory.WaitForAllTasksToRun();
+
+ // Post |kNumTasksPostedPerThread| tasks that should all run despite the fact
+ // that only one thread in |thread_pool_| isn't busy.
+ for (size_t i = 0; i < kNumTasksPostedPerThread; ++i)
+ factory.PostTestTask(task_runner, false, nullptr);
+ factory.WaitForAllTasksToRun();
+
+ // Release tasks waiting on |event|.
+ event.Signal();
+
+ // Wait until all worker threads are idle to be sure that no task accesses
+ // |factory| after it is destroyed.
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+}
+
+TEST_F(TaskSchedulerThreadPoolTest, Saturate) {
+ TaskFactory factory;
+
+ // Verify that it is possible to have |kNumThreadsInThreadPool| tasks running
+ // simultaneously.
+ WaitableEvent event(true, false);
+ auto task_runner = thread_pool_->CreateTaskRunnerWithTraits(
+ TaskTraits(), ExecutionMode::PARALLEL);
+ for (size_t i = 0; i < kNumThreadsInThreadPool; ++i)
+ factory.PostTestTask(task_runner, false, &event);
+ factory.WaitForAllTasksToRun();
+
+ // Release tasks waiting on |event|.
+ event.Signal();
+
+ // Wait until all worker threads are idle to be sure that no task accesses
+ // |factory| after it is destroyed.
+ thread_pool_->WaitForAllWorkerThreadsIdleForTesting();
+}
+
+} // namespace
+} // namespace internal
+} // namespace base

Powered by Google App Engine
This is Rietveld 408576698