Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2467)

Unified Diff: base/android/java/src/org/chromium/base/ThreadUtils.java

Issue 1708763003: Fix strict mode violation in TabPersistentStore.cleanupPersistentData() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-persist-1
Patch Set: fix test, address commetns Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/ThreadUtils.java
diff --git a/base/android/java/src/org/chromium/base/ThreadUtils.java b/base/android/java/src/org/chromium/base/ThreadUtils.java
index ef2887acd0c97e5c8ca97beb489c1dbe50302d98..107559b15a2269eb768a9c4fc403ea3f20c396dc 100644
--- a/base/android/java/src/org/chromium/base/ThreadUtils.java
+++ b/base/android/java/src/org/chromium/base/ThreadUtils.java
@@ -193,6 +193,14 @@ public class ThreadUtils {
}
/**
+ * Asserts that the current thread is running on a thread dedicated to IO.
+ */
+ public static void assertOnFileThread() {
+ // TODO(agrieve): May want to dedicate a thread(pool) to IO (or join native's File thread).
gone 2016/02/18 17:45:35 nit: Until it's actually a dedicated thread, maybe
agrieve 2016/02/23 21:28:38 Reverted for now. Makes sense though.
+ assert !runningOnUiThread();
+ }
+
+ /**
* @return true iff the current thread is the main (UI) thread.
*/
public static boolean runningOnUiThread() {

Powered by Google App Engine
This is Rietveld 408576698