Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1708753002: Subzero. ARM32. Enable hwdiv-arm crosstests. (Closed)

Created:
4 years, 10 months ago by John
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M Makefile.standalone View 1 2 chunks +6 lines, -1 line 0 comments Download
M pydir/crosstest_generator.py View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
John
4 years, 10 months ago (2016-02-17 19:47:47 UTC) #2
Eric Holk
lgtm
4 years, 10 months ago (2016-02-17 20:42:10 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1708753002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1708753002/diff/1/Makefile.standalone#newcode453 Makefile.standalone:453: -e arm32,sandbox,hwdiv-arm \ untabify this line
4 years, 10 months ago (2016-02-17 20:51:12 UTC) #4
John
https://codereview.chromium.org/1708753002/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1708753002/diff/1/Makefile.standalone#newcode453 Makefile.standalone:453: -e arm32,sandbox,hwdiv-arm \ On 2016/02/17 20:51:12, stichnot wrote: > ...
4 years, 10 months ago (2016-02-18 15:54:15 UTC) #5
John
4 years, 10 months ago (2016-02-18 16:02:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
94e97f6a75cf87c7e547d4d9ff1a9acbc9275cea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698