Add retry logic to install-sysroot.py

Add retry logic to install-sysroot.py

BUG=587282
Committed: https://crrev.com/7b32e30f5c21ed36898e73eb332a9a2d0917bbd1
Cr-Commit-Position: refs/heads/master@{#376020}

[Sam Clegg, 2016-02-17 19:47:10]

sbc@chromium.org changed reviewers:
+ thestig@chromium.org

[Sam Clegg, 2016-02-17 19:49:06]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 19:50:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708743002/20001

[commit-bot: I haz the power, 2016-02-17 20:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 20:16:19]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-02-17 20:49:52]

lgtm

https://codereview.chromium.org/1708743002/diff/20001/build/linux/sysroot_scr...
File build/linux/sysroot_scripts/install-sysroot.py (right):

https://codereview.chromium.org/1708743002/diff/20001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/install-sysroot.py:165: # Re-try download in order
to mitigate network falkiness.
typo

https://codereview.chromium.org/1708743002/diff/20001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/install-sysroot.py:173: elif num_retries:
no elif / else after a return.

https://codereview.chromium.org/1708743002/diff/20001/build/linux/sysroot_scr...
build/linux/sysroot_scripts/install-sysroot.py:180: raise Error('download
command failed (%s): %s' % (rtn, cmd))
%s seems to work, but shouldn't it be %d since |rtn| is an int?

[hans, 2016-02-17 21:21:05]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2016-02-17 21:21:05]

Would it suffice to just add "--retry 5" to the curl invocation?

[Sam Clegg, 2016-02-17 22:14:01]

On 2016/02/17 21:21:05, hans wrote:
> Would it suffice to just add "--retry 5" to the curl invocation?

Ack.. didn't think of looking for such a feature in curl.

[Sam Clegg, 2016-02-17 22:20:01]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[Sam Clegg, 2016-02-17 22:20:32]

Description was changed from

==========
Add retry logic to install-sysroot.py

BUG=587282
==========

to

==========
Add retry logic to install-sysroot.py

BUG=587282
==========

[Sam Clegg, 2016-02-17 22:20:44]

Simplified to use curl --retry

[commit-bot: I haz the power, 2016-02-17 22:22:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708743002/40001

[Lei Zhang, 2016-02-17 22:41:20]

still lgtm

[Sam Clegg, 2016-02-17 22:42:07]

The CQ bit was unchecked by sbc@chromium.org

[Sam Clegg, 2016-02-17 22:42:13]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-02-17 22:43:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708743002/40001

[commit-bot: I haz the power, 2016-02-17 22:58:28]

Description was changed from

==========
Add retry logic to install-sysroot.py

BUG=587282
==========

to

==========
Add retry logic to install-sysroot.py

BUG=587282
==========

[commit-bot: I haz the power, 2016-02-17 22:58:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 22:59:21]

Description was changed from

==========
Add retry logic to install-sysroot.py

BUG=587282
==========

to

==========
Add retry logic to install-sysroot.py

BUG=587282

Committed: https://crrev.com/7b32e30f5c21ed36898e73eb332a9a2d0917bbd1
Cr-Commit-Position: refs/heads/master@{#376020}
==========

[commit-bot: I haz the power, 2016-02-17 22:59:22]

Patchset 3 (id:??) landed as
https://crrev.com/7b32e30f5c21ed36898e73eb332a9a2d0917bbd1
Cr-Commit-Position: refs/heads/master@{#376020}