Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 170873008: Changes to the Clang packaging script: (Closed)

Created:
6 years, 10 months ago by Alexander Potapenko
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Changes to the Clang packaging script: - package the iOS simulator ASan runtime and set the correct LC_ID_DYLIB for it - declare gcc_toolchain to fix the "unbound variable" errors BUG=170629, 344836 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252561

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M tools/clang/scripts/package.sh View 1 2 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
Nico, can you please take a look? Anticipating your question, the iossim runtime library has ...
6 years, 10 months ago (2014-02-19 11:34:07 UTC) #1
Nico
Can you reupload? I'm getting Error fetching svn://svn.chromium.org/chrome/trunk/src/tools/clang/scripts/package.sh?rev=251751: InvalidURLError: Invalid request URL: svn://svn.chromium.org/chrome/trunk/src/tools/clang/scripts/package.sh?rev=251751
6 years, 10 months ago (2014-02-19 18:14:09 UTC) #2
Alexander Potapenko
On 2014/02/19 18:14:09, Nico wrote: > Can you reupload? I'm getting Error fetching > svn://svn.chromium.org/chrome/trunk/src/tools/clang/scripts/package.sh?rev=251751: ...
6 years, 10 months ago (2014-02-20 08:19:33 UTC) #3
Nico
lgtm
6 years, 10 months ago (2014-02-21 04:51:32 UTC) #4
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 10 months ago (2014-02-21 07:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/170873008/40001
6 years, 10 months ago (2014-02-21 07:25:35 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 15:33:04 UTC) #7
Message was sent while issue was closed.
Change committed as 252561

Powered by Google App Engine
This is Rietveld 408576698