Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 17087010: Make the ninja pool math correct. (Closed)

Created:
7 years, 6 months ago by iannucci
Modified:
7 years, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Make the ninja pool math correct. R=scottmg@chromium.org BUG= Committed: https://code.google.com/p/gyp/source/detail?r=1652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
iannucci
7 years, 6 months ago (2013-06-21 20:45:42 UTC) #1
scottmg
sure, lgtm
7 years, 6 months ago (2013-06-21 20:49:18 UTC) #2
iannucci
7 years, 6 months ago (2013-06-21 20:55:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698