Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1708683003: [Android] Switch UrlOverridingTest over to the EmbeddedTestServer. (Closed)

Created:
4 years, 10 months ago by jbudorick
Modified:
4 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch UrlOverridingTest over to the EmbeddedTestServer. BUG=488195 Committed: https://crrev.com/f487e92cca9484a43eb5392b7d4bf21494faf801 Cr-Commit-Position: refs/heads/master@{#376040}

Patch Set 1 #

Total comments: 2

Patch Set 2 : yfriedman comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -35 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java View 1 7 chunks +70 lines, -32 lines 0 comments Download
M chrome/test/data/android/url_overriding/navigation_with_fallback_url.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/url_overriding/navigation_with_fallback_url_parent_frame.html View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
This is the last suite for chrome_public_test_apk. I need to make a few changes elsewhere, ...
4 years, 10 months ago (2016-02-17 20:47:06 UTC) #2
Yaron
lgtm https://codereview.chromium.org/1708683003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java (right): https://codereview.chromium.org/1708683003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java#newcode213 chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java:213: updateFailureReason(expectedFinalUrl + " != " + tab.getUrl()); "Expected:" ...
4 years, 10 months ago (2016-02-17 21:47:37 UTC) #3
jbudorick
https://codereview.chromium.org/1708683003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java (right): https://codereview.chromium.org/1708683003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java#newcode213 chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java:213: updateFailureReason(expectedFinalUrl + " != " + tab.getUrl()); On 2016/02/17 ...
4 years, 10 months ago (2016-02-17 22:51:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708683003/20001
4 years, 10 months ago (2016-02-17 22:52:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 00:06:58 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 00:08:08 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f487e92cca9484a43eb5392b7d4bf21494faf801
Cr-Commit-Position: refs/heads/master@{#376040}

Powered by Google App Engine
This is Rietveld 408576698