Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1708663003: CR tweaks that missed the last CL (Closed)

Created:
4 years, 10 months ago by brucedawson
Modified:
4 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CR tweaks that missed the last CL In crrev.com/1676943002 a couple of CR comments were made after the commit button was checked. This applies those fixes. BUG=440500 Committed: https://crrev.com/c6f6c69e52a78e9feeb7f7b82283764386f5570f Cr-Commit-Position: refs/heads/master@{#376843}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M build/config/win/msvs_dependencies.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M build/vs_toolchain.py View 3 chunks +10 lines, -10 lines 2 comments Download

Messages

Total messages: 12 (5 generated)
brucedawson
Here's the promised fixes to that earlier change.
4 years, 10 months ago (2016-02-17 21:45:45 UTC) #3
brucedawson
PTAL
4 years, 10 months ago (2016-02-22 20:55:37 UTC) #4
Nico
lgtm https://codereview.chromium.org/1708663003/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/1708663003/diff/1/build/vs_toolchain.py#newcode188 build/vs_toolchain.py:188: print 'Copying %s to %s...' % (ucrt_src_dir, target_dir) ...
4 years, 10 months ago (2016-02-22 21:01:06 UTC) #5
brucedawson
https://codereview.chromium.org/1708663003/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/1708663003/diff/1/build/vs_toolchain.py#newcode188 build/vs_toolchain.py:188: print 'Copying %s to %s...' % (ucrt_src_dir, target_dir) On ...
4 years, 10 months ago (2016-02-22 21:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708663003/1
4 years, 10 months ago (2016-02-22 21:44:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 23:09:26 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 23:11:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6f6c69e52a78e9feeb7f7b82283764386f5570f
Cr-Commit-Position: refs/heads/master@{#376843}

Powered by Google App Engine
This is Rietveld 408576698