content/renderer/service_worker/embedded_worker_dispatcher.cc - Issue 1708583003: Pass data saver pref value into embedded worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 1708583003: Pass data saver pref value into embedded worker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/embedded_worker_dispatcher.cc

diff --git a/content/renderer/service_worker/embedded_worker_dispatcher.cc b/content/renderer/service_worker/embedded_worker_dispatcher.cc

index 74d711d54e1a91294ef8ac88d9d28becb024f8dd..7ed1a4131bfd9e6cea7507cbd604d42217f12780 100644

--- a/content/renderer/service_worker/embedded_worker_dispatcher.cc

+++ b/content/renderer/service_worker/embedded_worker_dispatcher.cc

@@ -97,8 +97,9 @@ void EmbeddedWorkerDispatcher::OnStartWorker(

params.wait_for_debugger ?

blink::WebEmbeddedWorkerStartData::WaitForDebugger :

blink::WebEmbeddedWorkerStartData::DontWaitForDebugger;

- start_data.v8CacheOptions =

- static_cast<blink::WebSettings::V8CacheOptions>(params.v8_cache_options);

+ start_data.v8CacheOptions = static_cast<blink::WebSettings::V8CacheOptions>(

+ params.settings.v8_cache_options);

+ start_data.dataSaverEnabled = params.settings.data_saver_enabled;

start_data.pauseAfterDownloadMode =

params.pause_after_download

? blink::WebEmbeddedWorkerStartData::PauseAfterDownload