[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}

Committed: https://crrev.com/3b1211ac2f1fbdf67c3f759f6c3f41f6e19f432b
Cr-Commit-Position: refs/heads/master@{#34146}

[Michael Starzinger, 2016-02-17 14:13:02]

LGTM if impact is negligible. So much code. :)

[Benedikt Meurer, 2016-02-17 15:38:02]

Let's see... reverting if it tanks.

[Benedikt Meurer, 2016-02-17 15:38:08]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-02-17 15:38:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708523002/1

[commit-bot: I haz the power, 2016-02-17 15:50:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 15:51:18]

Description was changed from

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org
==========

to

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

[commit-bot: I haz the power, 2016-02-17 15:51:19]

Patchset 1 (id:??) landed as
https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}

[Michael Achenbach, 2016-02-17 19:40:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1709693002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for adding arm flakes:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20si...
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20si...

And some more....

[Benedikt Meurer, 2016-02-18 04:57:28]

On 2016/02/17 19:40:53, Michael Achenbach wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1709693002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Speculative revert for adding arm
flakes:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20si...
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20si...
> 
> And some more....

This is sort of worrying, as it means that the "slow path" for
Array.prototype.join and friends is buggy, which we now always take (and which
isn't that slow anyways)... Yak shaving!

[Benedikt Meurer, 2016-02-19 08:50:54]

Description was changed from

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

to

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

[Benedikt Meurer, 2016-02-19 08:51:33]

Cannot reproduce. Speculative reland.

[Benedikt Meurer, 2016-02-19 08:51:45]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-02-19 08:51:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708523002/1

[commit-bot: I haz the power, 2016-02-19 09:12:46]

Description was changed from

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

to

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

[commit-bot: I haz the power, 2016-02-19 09:12:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-19 09:13:19]

Description was changed from

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}
==========

to

==========
[fullcodegen] Remove the hacky %_FastOneByteArrayJoin intrinsic.

This intrinsic was only supported in fullcodegen, and is actually no
longer relevant for SunSpider peak performance it seems, so let's get
rid of it and maybe just implement Array.prototype.join with a fast
path at some point instead.

R=mstarzinger@chromium.org

Committed: https://crrev.com/ccf12b4bede3f1ce3ce14fb33bcc4041525a40af
Cr-Commit-Position: refs/heads/master@{#34084}

Committed: https://crrev.com/3b1211ac2f1fbdf67c3f759f6c3f41f6e19f432b
Cr-Commit-Position: refs/heads/master@{#34146}
==========

[commit-bot: I haz the power, 2016-02-19 09:13:20]

Patchset 1 (id:??) landed as
https://crrev.com/3b1211ac2f1fbdf67c3f759f6c3f41f6e19f432b
Cr-Commit-Position: refs/heads/master@{#34146}