GN: Normalize the build directory path

GN: Normalize the build directory path

BUG=586906
TEST=ln -s /tmp out_tmp && out/gn/gn gen out_tmp/Release

Committed: https://crrev.com/89d33db3bfd53fbb3d85bb218ad4db8489a4dc34
Cr-Commit-Position: refs/heads/master@{#375970}

[hashimoto, 2016-02-17 11:38:16]

hashimoto@chromium.org changed reviewers:
+ brettw@chromium.org

[hashimoto, 2016-02-17 11:40:12]

I was thinking about using base::NormalizeFilePath() for this, but realized that
the function returns false when the path points to a directory (to be consistent
with Windows).
So switched to use realpath() on POSIX systems, and doing nothing on Windows.

[brettw, 2016-02-17 18:19:33]

lgtm

[brettw, 2016-02-17 20:21:09]

I'm assuming you want to commit so I'll commit this and see if I can do a roll.

[brettw, 2016-02-17 20:21:14]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-02-17 20:24:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708513002/1

[commit-bot: I haz the power, 2016-02-17 20:39:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-17 20:40:43]

Description was changed from

==========
GN: Normalize the build directory path

BUG=586906
TEST=ln -s /tmp out_tmp && out/gn/gn gen out_tmp/Release
==========

to

==========
GN: Normalize the build directory path

BUG=586906
TEST=ln -s /tmp out_tmp && out/gn/gn gen out_tmp/Release

Committed: https://crrev.com/89d33db3bfd53fbb3d85bb218ad4db8489a4dc34
Cr-Commit-Position: refs/heads/master@{#375970}
==========

[commit-bot: I haz the power, 2016-02-17 20:40:44]

Patchset 1 (id:??) landed as
https://crrev.com/89d33db3bfd53fbb3d85bb218ad4db8489a4dc34
Cr-Commit-Position: refs/heads/master@{#375970}

[brettw, 2016-02-17 22:22:24]

On 2016/02/17 20:40:44, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/89d33db3bfd53fbb3d85bb218ad4db8489a4dc34
> Cr-Commit-Position: refs/heads/master@{#375970}

Looks like this is failing on the Mac bot:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_...

/b/build/slave/mac_gn/build/src/buildtools/mac/gn gen //out/Release
'--args=is_debug=false is_component_build=false use_goma=true
goma_dir="/b/build/goma" symbol_level=1 dcheck_always_on=true' --check
  -> returned 1

I'll revert and explain the problem in a follow-up.

[brettw, 2016-02-17 22:22:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1705313002/ by brettw@chromium.org.

The reason for reverting is: Doesn't work on bots (link in previous comment)..