Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2136)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java

Issue 17085003: Implement new error code: StaticTypeWarningCode.NON_TYPE_AS_TYPE_ARGUMENT (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
index c5d711754c84f96cdc4c3f10b809da31a294e6ca..88a3249af3df9930642bc930478a915e746f155e 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java
@@ -476,6 +476,8 @@ public class TypeResolverVisitor extends ScopedVisitor {
reportError(StaticWarningCode.TYPE_TEST_NON_TYPE, typeName, typeName.getName());
} else if (isTypeNameTargetInRedirectedConstructor(node)) {
reportError(StaticWarningCode.REDIRECT_TO_NON_CLASS, typeName, typeName.getName());
+ } else if (isTypeNameInTypeArgumentList(node)) {
+ reportError(StaticTypeWarningCode.NON_TYPE_AS_TYPE_ARGUMENT, typeName, typeName.getName());
} else {
reportError(StaticWarningCode.UNDEFINED_CLASS, typeName, typeName.getName());
}
@@ -516,6 +518,8 @@ public class TypeResolverVisitor extends ScopedVisitor {
reportError(StaticWarningCode.CAST_TO_NON_TYPE, typeName, typeName.getName());
} else if (isTypeNameInIsExpression(node)) {
reportError(StaticWarningCode.TYPE_TEST_NON_TYPE, typeName, typeName.getName());
+ } else if (isTypeNameInTypeArgumentList(node)) {
+ reportError(StaticTypeWarningCode.NON_TYPE_AS_TYPE_ARGUMENT, typeName, typeName.getName());
} else {
ASTNode parent = typeName.getParent();
while (parent instanceof TypeName) {
@@ -840,6 +844,16 @@ public class TypeResolverVisitor extends ScopedVisitor {
}
/**
+ * Checks if the given type name used in a type argument list.
+ *
+ * @param typeName the type name to analyzer
+ * @return {@code true} if the given type name is in a type argument list
+ */
+ private boolean isTypeNameInTypeArgumentList(TypeName typeName) {
+ return typeName.getParent() instanceof TypeArgumentList;
+ }
+
+ /**
* Checks if the given type name is the target in a redirected constructor.
*
* @param typeName the type name to analyzer

Powered by Google App Engine
This is Rietveld 408576698