Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 170843009: Revert 251959 "Refactor the TrayAudio code so that it can be use..." (Closed)

Created:
6 years, 10 months ago by earthdok
Modified:
6 years, 10 months ago
Reviewers:
zturner
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251959 "Refactor the TrayAudio code so that it can be use..." Reverted due to memory leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/15922 > Refactor the TrayAudio code so that it can be used by other platforms. > The motivation here is to introduce the volume slider tray UI into > Windows Ash. > > This change does not actually add tray audio UI to other platforms, > only moves some non-chromeos specific things out of the chromeos > platform folders, so that we can hook in the native Audio APIs > of other platforms to the tray UI. > > At a high level, this change does the following: > > 1) Move tray_audio out of chromeos/ so that other platforms can > use the UI that it provides. > 2) Decouples TrayAudio from CrasAudioHandler by introducing a > new delegate, in a similar vein to what is done with all the other > handlers (e.g. the BluetoothHandler) > 3) Move the additional views (VolumeView, etc) to their own files > so they can be used by other platforms as well. > > TEST= > On CrOS physical device, verified that: > 1) Keyboard volume buttons function appropriately and display the > volume view > 2) AudioDetailView still is accessible at the correct times > 3) Adjusting the volume (via the keyboard shortcuts or via the > slider) correctly change the output volume. > 4) UI still behaves correctly (e.g. icons update as the volume > changes, mute button works, etc). > > BUG=227247 > > Review URL: https://codereview.chromium.org/163953007 TBR=zturner@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1277 lines) Patch
M trunk/src/ash/ash.gyp View 1 chunk +2 lines, -12 lines 0 comments Download
M trunk/src/ash/ash_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/ash_switches.cc View 1 chunk +1 line, -5 lines 0 comments Download
D trunk/src/ash/system/audio/audio_observer.h View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/ash/system/audio/tray_audio.h View 1 chunk +0 lines, -64 lines 0 comments Download
D trunk/src/ash/system/audio/tray_audio.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D trunk/src/ash/system/audio/tray_audio_delegate.h View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/ash/system/audio/volume_view.h View 1 chunk +0 lines, -90 lines 0 comments Download
D trunk/src/ash/system/audio/volume_view.cc View 1 chunk +0 lines, -332 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/audio_detailed_view.h View 1 chunk +0 lines, -66 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/audio_detailed_view.cc View 1 chunk +0 lines, -177 lines 0 comments Download
A + trunk/src/ash/system/chromeos/audio/tray_audio.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/system/chromeos/audio/tray_audio.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/tray_audio_chromeos.h View 1 chunk +0 lines, -42 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/tray_audio_chromeos.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/tray_audio_delegate_chromeos.h View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/ash/system/chromeos/audio/tray_audio_delegate_chromeos.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M trunk/src/ash/system/tray/system_tray.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/ash/system/tray/system_tray_notifier.h View 4 chunks +1 line, -11 lines 0 comments Download
M trunk/src/ash/system/tray/system_tray_notifier.cc View 2 chunks +0 lines, -43 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 3 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 3 chunks +1 line, -34 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chromeos/audio/cras_audio_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
earthdok
6 years, 10 months ago (2014-02-19 08:38:16 UTC) #1
earthdok
6 years, 10 months ago (2014-02-19 08:38:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r252009.

Powered by Google App Engine
This is Rietveld 408576698