Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: net/websockets/websocket_channel_test.cc

Issue 170843007: Introduce url::Origin to represent Web Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_channel_test.cc
diff --git a/net/websockets/websocket_channel_test.cc b/net/websockets/websocket_channel_test.cc
index 81c2f29e15976fa7d4f5faa74b5720caf2904465..cfa6f92c93a4ac16b66257e4f9bca9e567c0f7ab 100644
--- a/net/websockets/websocket_channel_test.cc
+++ b/net/websockets/websocket_channel_test.cc
@@ -680,7 +680,7 @@ struct ArgumentCopyingWebSocketStreamCreator {
scoped_ptr<WebSocketStreamRequest> Create(
const GURL& socket_url,
const std::vector<std::string>& requested_subprotocols,
- const GURL& origin,
+ const std::string& origin,
URLRequestContext* url_request_context,
const BoundNetLog& net_log,
scoped_ptr<WebSocketStream::ConnectDelegate> connect_delegate) {
@@ -694,7 +694,7 @@ struct ArgumentCopyingWebSocketStreamCreator {
}
GURL socket_url;
- GURL origin;
+ std::string origin;
std::vector<std::string> requested_subprotocols;
URLRequestContext* url_request_context;
BoundNetLog net_log;
@@ -754,7 +754,7 @@ class WebSocketChannelTest : public ::testing::Test {
// A struct containing the data that will be used to connect the channel.
// Grouped for readability.
struct ConnectData {
- ConnectData() : socket_url("ws://ws/"), origin("http://ws/") {}
+ ConnectData() : socket_url("ws://ws/"), origin("http://ws") {}
// URLRequestContext object.
URLRequestContext url_request_context;
@@ -764,7 +764,7 @@ class WebSocketChannelTest : public ::testing::Test {
// Requested protocols for the request.
std::vector<std::string> requested_subprotocols;
// Origin of the request
- GURL origin;
+ std::string origin;
// A fake WebSocketStreamCreator that just records its arguments.
ArgumentCopyingWebSocketStreamCreator creator;
@@ -959,7 +959,7 @@ class WebSocketChannelReceiveUtf8Test : public WebSocketChannelStreamTest {
// passed to the creator function.
TEST_F(WebSocketChannelTest, EverythingIsPassedToTheCreatorFunction) {
connect_data_.socket_url = GURL("ws://example.com/test");
- connect_data_.origin = GURL("http://example.com/test");
+ connect_data_.origin = "http://example.com";
connect_data_.requested_subprotocols.push_back("Sinbad");
CreateChannelAndConnect();

Powered by Google App Engine
This is Rietveld 408576698