url/origin.cc - Issue 170843007: Introduce url::Origin to represent Web Origin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/origin.cc

Issue 170843007: Introduce url::Origin to represent Web Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "url/origin.h"

	6

	7 #include "base/strings/string_util.h"

	8

	9 namespace url {

	10

	11 Origin::Origin() {}

	12

	13 Origin::Origin(const std::string& origin) : string_(origin) {

	14 DCHECK(origin == "null" \|\| MatchPattern(origin, "?://?"));
	brettw 2014/03/12 05:34:54 Seems to me that this should also accept an empty Seems to me that this should also accept an empty string, or the default constructor should initialize to null to make clear that an empty origin string is always illegal. yhirano 2014/03/12 05:48:20 Thanks, done. Show quoted text On 2014/03/12 05:34:54, brettw wrote: > Seems to me that this should also accept an empty string, or the default > constructor should initialize to null to make clear that an empty origin string > is always illegal. Thanks, done.
	15 DCHECK_NE(origin[origin.size() - 1], '/');
	brettw 2014/03/12 05:34:54 ...and this shouldn't crash on empty string. ...and this shouldn't crash on empty string. yhirano 2014/03/12 05:48:20 Done. Show quoted text On 2014/03/12 05:34:54, brettw wrote: > ...and this shouldn't crash on empty string. Done.
	16 }

	17

	18 } // namespace url

OLD	NEW

« no previous file with comments | « url/origin.h ('k') | url/origin_unittest.cc » ('j') | no next file with comments »