url/serialized_origin.cc - Issue 170843007: Introduce url::Origin to represent Web Origin.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: url/serialized_origin.cc

Issue 170843007: Introduce url::Origin to represent Web Origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "url/serialized_origin.h"

	6

	7 #include <ostream>

	8 #include <string>
	brettw 2014/03/10 20:59:04 You don't need this since the header file uses it. You don't need this since the header file uses it. yhirano 2014/03/12 02:27:05 Done. Show quoted text On 2014/03/10 20:59:04, brettw wrote: > You don't need this since the header file uses it. Done.
	9

	10 SerializedOrigin::SerializedOrigin() {}

	11

	12 SerializedOrigin::SerializedOrigin(const std::string& origin)

	13 : string_(origin) {}
	brettw 2014/03/10 20:59:04 It seems like there is an expected format of the o It seems like there is an expected format of the origin information. Is this something we could assert here? Like could this make a GURL and make sure it's the same except for a trailing slash? yhirano 2014/03/12 02:27:05 Done. Show quoted text On 2014/03/10 20:59:04, brettw wrote: > It seems like there is an expected format of the origin information. Is this > something we could assert here? Like could this make a GURL and make sure it's > the same except for a trailing slash? Done.
	14

	15 std::ostream& operator<<(std::ostream& out,

	16 const SerializedOrigin& origin) {

	17 return out << origin.string();

	18 }

	19

OLD	NEW