Fix BrowserActionApiTest.DynamicBrowserAction interaction with dev-mode highlighting.

Fix BrowserActionApiTest.DynamicBrowserAction interaction with dev-mode highlighting.

With dev-mode highlighting (on stable/beta channel, or with the --force-dev-mode-highlighting=1 flag), in Views, unpacked extension browser action iicons (such as the ones in this test) are given a different background. Adjust our test expectations accordingly.

This patch also cleans up the other BrowserActionApiTests somewhat.

BUG=333008
TEST=browser_tests --gtest_filter=BrowserActionApiTest.DynamicBrowserAction --force-dev-mode-highlighting=1

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251978

[Yoyo Zhou, 2014-02-19 01:02:26]

Jeffrey, can you review this? Finnur would be the best reviewer, but I'd like to
get this in before the M34 branch tonight.

[Jeffrey Yasskin, 2014-02-19 01:13:34]

lgtm, but you might be able to simplify the change:

https://codereview.chromium.org/170843005/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
(right):

https://codereview.chromium.org/170843005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:93: if
(extensions::DevModeBubbleController::IsDevModeExtension(extension_))
Can we pass this extension as a function argument rather than implicitly through
the class?

https://codereview.chromium.org/170843005/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:317:
extension_ = GetSingleLoadedExtension();
I don't think you have to make this change, since AddBackgroundForViews()
doesn't appear to be called in this test.

[Yoyo Zhou, 2014-02-19 01:27:34]

Good call. Changed it to pass the Extension* as an argument to the helper.

[Yoyo Zhou, 2014-02-19 01:27:48]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-19 01:54:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/170843005/70001

[commit-bot: I haz the power, 2014-02-19 03:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 03:17:57]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Jeffrey Yasskin, 2014-02-19 03:41:12]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-02-19 03:41:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/170843005/70001

[commit-bot: I haz the power, 2014-02-19 06:45:35]

Change committed as 251978

[Finnur, 2014-02-19 11:50:50]

I love it. Thanks for doing this. I couldn't think of a way to fix this from the
dev mode side, glad to see that there's a simple fix on the test side of things!

LGTM.