scripts/master/factory/gclient_factory.py - Issue 170843003: Apply patch for bot_update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/master/factory/gclient_factory.py

Issue 170843003: Apply patch for bot_update (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: pylint Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/master/factory/gclient_factory.py

diff --git a/scripts/master/factory/gclient_factory.py b/scripts/master/factory/gclient_factory.py

index edd4285e2c5ca65968418d13eed7cfff1e689d55..5d85730393830eb423b27612486558c1490b45c4 100644

--- a/scripts/master/factory/gclient_factory.py

+++ b/scripts/master/factory/gclient_factory.py

@@ -197,7 +197,8 @@ class GClientFactory(object):

# this does activate, it will emit a BOT_UPDATED file in the build/

# directory to signal to the other gclient update steps to no-op.

code_review_site = config.Master.Master4.code_review_site

- factory_cmd_obj.AddBotUpdateStep(env, gclient_spec, code_review_site)

+ factory_cmd_obj.AddBotUpdateStep(env, gclient_spec, self._revision_mapping,

+ server=code_review_site)

# svn timeout is 2 min; we allow 5

« no previous file with comments | « scripts/master/factory/commands.py ('k') | scripts/slave/bot_update.py » ('j') | no next file with comments »