Apply patch for bot_update

scripts/slave/bot_update.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import codecs
 import copy
 import optparse
 import os
 import pprint
@@ skipping 322 matching lines @@
       else:
         # rev_num is actually a git hash or ref, we can just use it.
         git_ref = revision
       git('checkout', git_ref, cwd=sln_dir)
     else:
       git('checkout', 'origin/master', cwd=sln_dir)
 
     first_solution = False
 
 
+def _download(url):
+  """Fetch url and return content, with retries for flake."""
+  attempts_left = 3

[agable, 2014/02/18 22:36:10]

This should use the same RETRIES mechanism as call().

[Ryan Tseng, 2014/02/19 22:05:40]

Done.

+  while attempts_left:
+    attempts_left -= 1
+    try:
+      return urllib2.urlopen(url).read()
+    except Exception:
+      if not attempts_left:
+        raise
+      pass
+
+
 def apply_issue(issue, patchset, root, server):
-  pass
+  print 'Fetching patch from %s' % patch_url
+  patch_url = 'https://%s/download/issue%s_%s.diff' % (server, issue, patchset)
+  patch_data = _download(patch_url)
+  # Git patches have a/ at the beginning of source paths.  We strip that out
+  # with a sed script rather than the -p flag to patch so we can feed either
+  # Git or svn-style patches into the same apply command.
+  patch_data = re.sub(r'^(---|\+\+\+) a/', r'\1 ', patch_data, re.MULTILINE)

[agable, 2014/02/18 22:36:10]

So we are supporting svn-style patches? I guess we have to, until flag day. That
sucks a bit though. This is going to need thorough testing... for a feature that
goes out the window on flag day.

[Ryan Tseng, 2014/02/19 22:05:40]

Copypasta from here:
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/git_...

+  print 'Patch contents:'
+  print patch_data
+  git('apply', '--index', '-p0', '--3way', stdin=patch_data)

[agable, 2014/02/18 22:36:10]

No need to specify --index when --3way is passed.

[Ryan Tseng, 2014/02/19 22:05:40]

Also copypasta'ed, probably from a more simpler time
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/git_...

--index removed.

 
 
 def check_flag(flag_file):
   """Returns True if the flag file is present."""
   return os.path.isfile(flag_file)
 
 
 def delete_flag(flag_file):
   """Remove bot update flag."""
   if os.path.isfile(flag_file):
@@ skipping 73 matching lines @@
   else:
     delete_flag(options.flag_file)
     return
 
   # Get a checkout of each solution, without DEPS or hooks.
   # Calling git directory because there is no way to run Gclient without
   # invoking DEPS.
   print 'Fetching Git checkout'
   git_checkout(git_solutions, options.revision)
 
-  # TODO(hinoka): This must be implemented before we can turn this on for TS.
-  # if options.issue:
-  #   apply_issue(options.issue, options.patchset, options.root, options.server)
+  if options.issue:
+    apply_issue(options.issue, options.patchset, options.root, options.server)
 
   # Magic to get deps2git to work with internal DEPS.
   shutil.copyfile(S2G_INTERNAL_FROM_PATH, S2G_INTERNAL_DEST_PATH)
   deps2git(dir_names)
 
   gclient_configure(git_solutions)
   gclient_sync()
 
 
 if __name__ == '__main__':
   sys.exit(main())