Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170843002: Set a reasonable icon for the media galleries scan result dialog folder viewer. (Closed)

Created:
6 years, 10 months ago by vandebo (ex-Chrome)
Modified:
6 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, oshima+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Set a reasonable icon for the media galleries scan result dialog folder viewer. Resubmission of https://codereview.chromium.org/130263007/ with the binary resources added with dcommit. BUG=334309, 161119 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
D chrome/app/theme/default_100_percent/cros/file_types/folder.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/cros/file_types/folder.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_scan_result_dialog_cocoa.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
vandebo (ex-Chrome)
6 years, 10 months ago (2014-02-18 19:49:11 UTC) #1
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 19:49:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/170843002/1
6 years, 10 months ago (2014-02-18 19:50:01 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 20:28:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 20:28:31 UTC) #5
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 21:03:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/170843002/1
6 years, 10 months ago (2014-02-18 21:03:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:05:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 21:05:10 UTC) #9
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 21:35:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/170843002/1
6 years, 10 months ago (2014-02-18 21:35:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 21:35:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 10 months ago (2014-02-18 21:35:43 UTC) #13
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 10 months ago (2014-02-18 22:30:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/170843002/1
6 years, 10 months ago (2014-02-18 22:31:06 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 00:49:26 UTC) #16
Message was sent while issue was closed. 
Change committed as 251901

Powered by Google App Engine
This is Rietveld 408576698