Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 17084012: Fixes for unpremul decode. (Closed)

Created:
7 years, 6 months ago by scroggo
Modified:
7 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixes for unpremul decode. SkImageDecoder_CG.cpp: If a non opaque bitmap was decoded, and the caller wants unpremultiplied, unpremultiply the colors. Always use the RGB colorspace, since the other colorspaces do not match the desired bitmap format. ImageDecodingTest: Allow for a difference of 1 in each color component when comparing the result of premultiplying the unpremultiplied decode with the premultiplied decode, since I found an image (in WEBP format) where the unpremultiplied colors did not compare perfectly in my comparison. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9628

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M src/ports/SkImageDecoder_CG.cpp View 5 chunks +26 lines, -11 lines 1 comment Download
M tests/ImageDecodingTest.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
7 years, 6 months ago (2013-06-14 19:32:13 UTC) #1
reed1
lgtm w/ optimization suggestion/question. https://codereview.chromium.org/17084012/diff/1/src/ports/SkImageDecoder_CG.cpp File src/ports/SkImageDecoder_CG.cpp (right): https://codereview.chromium.org/17084012/diff/1/src/ports/SkImageDecoder_CG.cpp#newcode55 src/ports/SkImageDecoder_CG.cpp:55: U8CPU a = SkGetPackedA32(color); possibly ...
7 years, 6 months ago (2013-06-14 19:38:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/17084012/1
7 years, 6 months ago (2013-06-14 20:37:32 UTC) #3
scroggo
7 years, 6 months ago (2013-06-14 20:39:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r9628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698