Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1708363002: Revert of Sampling heap profiler data structure changes (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Sampling heap profiler data structure changes (patchset #10 id:180001 of https://codereview.chromium.org/1697903002/ ) Reason for revert: [Sheriff] Speculative revert for cpu profiler crashes on chromebooks: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/549 https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/550 Original issue's description: > Sampling heap profiler data structure changes > > Previously, the sampling heap profiler stored a list of samples and then > built a tree representation when the profile was queried by calling > GetAllocationProfile. This change reduces duplication by removing stacks > from all samples. Also, less information is stored in the tree > maintained by the profiler and remaining information (script name, line > no, etc) is resolved when a profile is requested. > > BUG= > > Committed: https://crrev.com/cdd55e2a3717723492d76f66810bf56b8de7f198 > Cr-Commit-Position: refs/heads/master@{#34119} TBR=ofrobots@google.com,ulan@chromium.org,hpayer@chromium.org,mattloring@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4578e52aefb8c4727742ce2e254613e482fdad1f Cr-Commit-Position: refs/heads/master@{#34128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -138 lines) Patch
M src/profiler/sampling-heap-profiler.h View 2 chunks +42 lines, -48 lines 0 comments Download
M src/profiler/sampling-heap-profiler.cc View 6 chunks +110 lines, -90 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
Created Revert of Sampling heap profiler data structure changes
4 years, 10 months ago (2016-02-18 19:04:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708363002/1
4 years, 10 months ago (2016-02-18 19:04:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 19:04:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4578e52aefb8c4727742ce2e254613e482fdad1f Cr-Commit-Position: refs/heads/master@{#34128}
4 years, 10 months ago (2016-02-18 19:05:45 UTC) #6
ofrobots
On 2016/02/18 19:05:45, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 10 months ago (2016-02-18 19:29:35 UTC) #7
Michael Achenbach
4 years, 10 months ago (2016-02-19 07:32:20 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1714493003/ by machenbach@chromium.org.

The reason for reverting is: Failure keeps lurking around after the revert. I'll
reland, sorry for the inconvenience!.

Powered by Google App Engine
This is Rietveld 408576698