Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: chrome/browser/lifetime/keep_alive_registry_unittest.cc

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments on PS15 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/lifetime/keep_alive_registry_unittest.cc
diff --git a/chrome/browser/lifetime/keep_alive_registry_unittest.cc b/chrome/browser/lifetime/keep_alive_registry_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..85613f62a02aa5445a80e29d5acc34c419feb052
--- /dev/null
+++ b/chrome/browser/lifetime/keep_alive_registry_unittest.cc
@@ -0,0 +1,64 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/lifetime/keep_alive_registry.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/lifetime/keep_alive_types.h"
+#include "chrome/browser/lifetime/scoped_keep_alive.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class KeepAliveRegistryTest : public testing::Test {
sky 2016/02/25 18:43:50 nit: remove this and instead using the TEST() macr
dgn 2016/02/26 11:51:59 Done.
+ public:
+ KeepAliveRegistryTest() {}
+ ~KeepAliveRegistryTest() override {}
+};
+
+// Test the WillKeepAlive state and when we interact with the browser with
+// a KeepAlive registered.
+TEST_F(KeepAliveRegistryTest, BasicKeepAliveTest) {
+ const int base_keep_alive_count = chrome::GetKeepAliveCountForTesting();
+ KeepAliveRegistry* registry = KeepAliveRegistry::GetInstance();
+
+ EXPECT_FALSE(registry->WillKeepAlive());
+
+ {
+ ScopedKeepAlive test_keep_alive(KeepAliveOrigin::TEST);
+
+ // We should require the browser to stay alive
+ EXPECT_EQ(base_keep_alive_count + 1, chrome::GetKeepAliveCountForTesting());
+ EXPECT_TRUE(registry->WillKeepAlive());
+ }
+
+ // We should be back to normal now.
+ EXPECT_EQ(base_keep_alive_count, chrome::GetKeepAliveCountForTesting());
+ EXPECT_FALSE(registry->WillKeepAlive());
+}
+
+// Test the WillKeepAlive state and when we interact with the browser with
+// more than one KeepAlive registered.
+TEST_F(KeepAliveRegistryTest, DoubleKeepAliveTest) {
+ const int base_keep_alive_count = chrome::GetKeepAliveCountForTesting();
+ KeepAliveRegistry* registry = KeepAliveRegistry::GetInstance();
+ scoped_ptr<ScopedKeepAlive> keep_alive_1, keep_alive_2;
+
+ keep_alive_1.reset(new ScopedKeepAlive(KeepAliveOrigin::TEST));
+ EXPECT_EQ(base_keep_alive_count + 1, chrome::GetKeepAliveCountForTesting());
+ EXPECT_TRUE(registry->WillKeepAlive());
+
+ keep_alive_2.reset(new ScopedKeepAlive(KeepAliveOrigin::TEST));
+ // We should not increment the count twice
+ EXPECT_EQ(base_keep_alive_count + 1, chrome::GetKeepAliveCountForTesting());
+ EXPECT_TRUE(registry->WillKeepAlive());
+
+ keep_alive_1.reset();
+ // We should not decrement the count before the last keep alive is released.
+ EXPECT_EQ(base_keep_alive_count + 1, chrome::GetKeepAliveCountForTesting());
+ EXPECT_TRUE(registry->WillKeepAlive());
+
+ keep_alive_2.reset();
+ EXPECT_EQ(base_keep_alive_count, chrome::GetKeepAliveCountForTesting());
+ EXPECT_FALSE(registry->WillKeepAlive());
+}

Powered by Google App Engine
This is Rietveld 408576698