chrome/browser/ui/apps/chrome_app_delegate.h - Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/apps/chrome_app_delegate.h

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address PS7 comments, replace strings by a struct ptr, chromeappdelegate ctor takes a boolean Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/apps/chrome_app_delegate.h

diff --git a/chrome/browser/ui/apps/chrome_app_delegate.h b/chrome/browser/ui/apps/chrome_app_delegate.h

index f1fed82e0271837e64108fa916653d261a37f1ec..37432322e4cfc2dbc249047835edbd02ac2a83dc 100644

--- a/chrome/browser/ui/apps/chrome_app_delegate.h

+++ b/chrome/browser/ui/apps/chrome_app_delegate.h

@@ -20,9 +20,9 @@ class ScopedKeepAlive;

class ChromeAppDelegate : public extensions::AppDelegate,

public content::NotificationObserver {

public:

- // Pass a ScopedKeepAlive to prevent the browser process from shutting down

- // while this object exists.

- explicit ChromeAppDelegate(scoped_ptr<ScopedKeepAlive> keep_alive);

+ // Params:

+ // keep_alive: Whether this object should keep the browser alive.

+ explicit ChromeAppDelegate(bool keep_alive);

~ChromeAppDelegate() override;

static void DisableExternalOpenForTesting();