Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use singleton instead of browserprocess Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/tabs/tabs_api.h" 5 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <limits> 9 #include <limits>
10 #include <utility> 10 #include <utility>
11 #include <vector> 11 #include <vector>
12 12
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "base/location.h" 15 #include "base/location.h"
16 #include "base/logging.h" 16 #include "base/logging.h"
17 #include "base/memory/ref_counted_memory.h" 17 #include "base/memory/ref_counted_memory.h"
18 #include "base/single_thread_task_runner.h" 18 #include "base/single_thread_task_runner.h"
19 #include "base/stl_util.h" 19 #include "base/stl_util.h"
20 #include "base/strings/pattern.h" 20 #include "base/strings/pattern.h"
21 #include "base/strings/string16.h" 21 #include "base/strings/string16.h"
22 #include "base/strings/string_number_conversions.h" 22 #include "base/strings/string_number_conversions.h"
23 #include "base/strings/string_util.h" 23 #include "base/strings/string_util.h"
24 #include "base/strings/stringprintf.h" 24 #include "base/strings/stringprintf.h"
25 #include "base/strings/utf_string_conversions.h" 25 #include "base/strings/utf_string_conversions.h"
26 #include "base/thread_task_runner_handle.h" 26 #include "base/thread_task_runner_handle.h"
27 #include "chrome/browser/apps/scoped_keep_alive.h"
28 #include "chrome/browser/chrome_notification_types.h" 27 #include "chrome/browser/chrome_notification_types.h"
29 #include "chrome/browser/extensions/api/tabs/tabs_constants.h" 28 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
30 #include "chrome/browser/extensions/api/tabs/windows_util.h" 29 #include "chrome/browser/extensions/api/tabs/windows_util.h"
31 #include "chrome/browser/extensions/extension_service.h" 30 #include "chrome/browser/extensions/extension_service.h"
32 #include "chrome/browser/extensions/extension_tab_util.h" 31 #include "chrome/browser/extensions/extension_tab_util.h"
33 #include "chrome/browser/extensions/tab_helper.h" 32 #include "chrome/browser/extensions/tab_helper.h"
34 #include "chrome/browser/extensions/window_controller.h" 33 #include "chrome/browser/extensions/window_controller.h"
35 #include "chrome/browser/extensions/window_controller_list.h" 34 #include "chrome/browser/extensions/window_controller_list.h"
35 #include "chrome/browser/lifetime/scoped_keep_alive.h"
36 #include "chrome/browser/prefs/incognito_mode_prefs.h" 36 #include "chrome/browser/prefs/incognito_mode_prefs.h"
37 #include "chrome/browser/profiles/profile.h" 37 #include "chrome/browser/profiles/profile.h"
38 #include "chrome/browser/sessions/session_tab_helper.h" 38 #include "chrome/browser/sessions/session_tab_helper.h"
39 #include "chrome/browser/translate/chrome_translate_client.h" 39 #include "chrome/browser/translate/chrome_translate_client.h"
40 #include "chrome/browser/ui/apps/chrome_app_delegate.h" 40 #include "chrome/browser/ui/apps/chrome_app_delegate.h"
41 #include "chrome/browser/ui/browser.h" 41 #include "chrome/browser/ui/browser.h"
42 #include "chrome/browser/ui/browser_commands.h" 42 #include "chrome/browser/ui/browser_commands.h"
43 #include "chrome/browser/ui/browser_finder.h" 43 #include "chrome/browser/ui/browser_finder.h"
44 #include "chrome/browser/ui/browser_list.h" 44 #include "chrome/browser/ui/browser_list.h"
45 #include "chrome/browser/ui/browser_navigator.h" 45 #include "chrome/browser/ui/browser_navigator.h"
(...skipping 540 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 586
587 #if defined(USE_ASH) 587 #if defined(USE_ASH)
588 if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) { 588 if (chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH) {
589 AppWindow::CreateParams create_params; 589 AppWindow::CreateParams create_params;
590 create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL; 590 create_params.window_type = AppWindow::WINDOW_TYPE_V1_PANEL;
591 create_params.window_key = extension_id; 591 create_params.window_key = extension_id;
592 create_params.window_spec.bounds = window_bounds; 592 create_params.window_spec.bounds = window_bounds;
593 create_params.focused = saw_focus_key && focused; 593 create_params.focused = saw_focus_key && focused;
594 AppWindow* app_window = new AppWindow( 594 AppWindow* app_window = new AppWindow(
595 window_profile, 595 window_profile,
596 new ChromeAppDelegate(make_scoped_ptr(new ScopedKeepAlive)), 596 new ChromeAppDelegate(
597 make_scoped_ptr(new ScopedKeepAlive("ChromeAppDelegate"))),
597 extension()); 598 extension());
598 AshPanelContents* ash_panel_contents = new AshPanelContents(app_window); 599 AshPanelContents* ash_panel_contents = new AshPanelContents(app_window);
599 app_window->Init(urls[0], ash_panel_contents, create_params); 600 app_window->Init(urls[0], ash_panel_contents, create_params);
600 WindowController* window_controller = 601 WindowController* window_controller =
601 WindowControllerList::GetInstance()->FindWindowById( 602 WindowControllerList::GetInstance()->FindWindowById(
602 app_window->session_id().id()); 603 app_window->session_id().id());
603 if (!window_controller) 604 if (!window_controller)
604 return false; 605 return false;
605 SetResult(window_controller->CreateWindowValueWithTabs(extension())); 606 SetResult(window_controller->CreateWindowValueWithTabs(extension()));
606 return true; 607 return true;
(...skipping 1517 matching lines...) Expand 10 before | Expand all | Expand 10 after
2124 ZoomModeToZoomSettings(zoom_mode, &zoom_settings); 2125 ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
2125 zoom_settings.default_zoom_factor.reset(new double( 2126 zoom_settings.default_zoom_factor.reset(new double(
2126 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel()))); 2127 content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
2127 2128
2128 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings); 2129 results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
2129 SendResponse(true); 2130 SendResponse(true);
2130 return true; 2131 return true;
2131 } 2132 }
2132 2133
2133 } // namespace extensions 2134 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698