Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1480)

Issue 1708303002: Revert of Add additive animation support for CSS property background-position (Closed)

Created:
4 years, 10 months ago by Theresa
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, Eric Willigers, Mikhail, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add additive animation support for CSS property background-position (patchset #7 id:120001 of https://codereview.chromium.org/1680803003/ ) Reason for revert: Causing compilation to fail on Android arm64, x64, x86, and MIPS dbg builds, see https://code.google.com/p/chromium/issues/detail?id=587875 Sheriff is reverting. Original issue's description: > Add additive animation support for CSS property background-position > > This patch adds support for composite modes on background-position > CSS animations via element.animate(). > > BUG=437696 > > Committed: https://crrev.com/38955fb584216cab36eccb20ac2672d38c198df7 > Cr-Commit-Position: refs/heads/master@{#376155} TBR=dstockwell@chromium.org,ericwilligers@chromium.org,haraken@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437696 Committed: https://crrev.com/2ccb404dc202e305cbf48c2404a51ee606235023 Cr-Commit-Position: refs/heads/master@{#376191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -502 lines) Patch
D third_party/WebKit/LayoutTests/animations/composition/background-position-composition.html View 1 chunk +0 lines, -89 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/background-position-origin-interpolation.html View 5 chunks +20 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/background-position-origin-interpolation-expected.txt View 3 chunks +60 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/responsive/background-position-responsive.html View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 4 chunks +26 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.h View 1 chunk +27 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 chunk +0 lines, -139 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/RefVector.h View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Theresa
Created Revert of Add additive animation support for CSS property background-position
4 years, 10 months ago (2016-02-18 17:23:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708303002/1
4 years, 10 months ago (2016-02-18 17:24:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 17:28:33 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 17:30:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ccb404dc202e305cbf48c2404a51ee606235023
Cr-Commit-Position: refs/heads/master@{#376191}

Powered by Google App Engine
This is Rietveld 408576698