gpu: Expose internal format R8 instead of RED.

ui/gl/gl_image_io_surface.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_image_io_surface.h"
 
 #include <map>
 
 #include "base/lazy_instance.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/stringize_macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/trace_event/memory_allocator_dump.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/process_memory_dump.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_helper.h"
+#include "ui/gl/gl_version_info.h"
 #include "ui/gl/scoped_binders.h"
 
 // Note that this must be included after gl_bindings.h to avoid conflicts.
 #include <OpenGL/CGLIOSurface.h>
 #include <Quartz/Quartz.h>
 #include <stddef.h>
 
 using gfx::BufferFormat;
 
 namespace gl {
@@ skipping 32 matching lines @@
     vec3 yuv = vec3(
         texture2DRect(a_y_texture, v_texCoord).r,
         texture2DRect(a_uv_texture, v_texCoord * 0.5).rg);
     gl_FragColor = vec4(yuv_matrix * (yuv + yuv_adj), 1.0);
   }
 );
 // clang-format on
 
 bool ValidInternalFormat(unsigned internalformat) {
   switch (internalformat) {
-    case GL_RED:
+    case GL_R8:
     case GL_BGRA_EXT:
     case GL_RGB:
     case GL_RGB_YCBCR_420V_CHROMIUM:
     case GL_RGB_YCBCR_422_CHROMIUM:
     case GL_RGBA:
       return true;
     default:
       return false;
   }
 }
@@ skipping 17 matching lines @@
     case BufferFormat::YUV_420:
       return false;
   }
 
   NOTREACHED();
   return false;
 }
 
 GLenum TextureFormat(BufferFormat format) {
   switch (format) {
-    case BufferFormat::R_8:
-      return GL_RED;
+    case BufferFormat::R_8: {
+      const gfx::GLVersionInfo* version_info =

[reveman, 2016/02/20 01:07:55]

Can this case be implemented this way?

return gfx::GLContext::GetCurrent()->GetVersionInfo()->IsES3Capable()
    ? GL_R8 : GL_RED;

[Daniele Castagna, 2016/02/20 01:16:16]

Done.

+          gfx::GLContext::GetCurrent()->GetVersionInfo();
+      if (version_info->IsAtLeastGL(3, 0) ||
+          version_info->IsAtLeastGLES(3, 0)) {
+        return GL_R8;
+      } else {
+        return GL_RED;
+      }
+    }
     case BufferFormat::BGRA_8888:
     case BufferFormat::RGBA_8888:
       return GL_RGBA;
     case BufferFormat::UYVY_422:
       return GL_RGB;
     case BufferFormat::YUV_420_BIPLANAR:
       return GL_RGB_YCBCR_420V_CHROMIUM;
     case BufferFormat::ATC:
     case BufferFormat::ATCIA:
     case BufferFormat::DXT1:
@@ skipping 297 matching lines @@
     g_widget_to_layer_map.Pointer()->erase(widget);
 }
 
 // static
 unsigned GLImageIOSurface::GetInternalFormatForTesting(
     gfx::BufferFormat format) {
   DCHECK(ValidFormat(format));
   return TextureFormat(format);
 }
 }  // namespace gl