Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: src/x64/lithium-x64.cc

Issue 17082003: Let NaN flow as double into HBranch (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/x64/lithium-x64.cc
diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc
index f776bf339f5d595e63a9a2633a72f7927efd4e97..195d48b23bf5dd1f3f9ea1a8f385342f0d9d4fb2 100644
--- a/src/x64/lithium-x64.cc
+++ b/src/x64/lithium-x64.cc
@@ -1015,9 +1015,11 @@ LInstruction* LChunkBuilder::DoBranch(HBranch* instr) {
LBranch* result = new(zone()) LBranch(UseRegister(value));
// Tagged values that are not known smis or booleans require a
// deoptimization environment.
+ ToBooleanStub::Types expected = instr->expected_input_types();
Representation rep = value->representation();
HType type = value->type();
- if (rep.IsTagged() && !type.IsSmi() && !type.IsBoolean()) {
+ if (rep.IsTagged() && !type.IsSmi() && !type.IsBoolean() &&
+ expected != ToBooleanStub::all_types()) {
Toon Verwaest 2013/06/18 17:01:52 Can you add a comment what expected == all_types m
return AssignEnvironment(result);
}
return result;

Powered by Google App Engine
This is Rietveld 408576698